Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Unit Tests - Dotnet#743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
mvarendorff wants to merge1 commit intoappwrite:master
base:master
Choose a base branch
Loading
frommvarendorff:feat-680-add-unit-tests-dotnet

Conversation

mvarendorff
Copy link
Contributor

What does this PR do?

This PR adds generated unit tests to the Dotnet SDK.

It also contains a deserialization fix that caused aKeyNotFoundException when a key was missing from the response map (I am not sure what the behaviour from the server is, whether the value is returned as null or doesn't exist in the map). The error came up when testing the User-related services that failed deserialization because thepassword field (amongst others) was not present in the mocked response.

Test Plan

Generate the SDK, then rundotnet test in the generated SDK'ssrc directory.

Related PRs and Issues

#680

Have you read theContributing Guidelines on issues?

Yup

@mvarendorff
Copy link
ContributorAuthor

I have a question on this particular one. Some SDKs contain tests for serializing using the respective Model classes. I did work on those in here as well but faced a fairly annoying problem: The output ofToMap fails when fed intoFrom due to the casting to JObject / JArray. Thus the question: How should I address that? I'd rather not meddle with the (de-)serialization too much if possible but I am not sure if leaving the tests out is a good idea either.

@abnegate
Copy link
Member

Are you make these test run automatically with the existing tests?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@adityaoberaiadityaoberaiAwaiting requested review from adityaoberai

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@mvarendorff@abnegate
[8]ページ先頭
©2009-2025 Movatter.jp