fix: errors in typing for Python 3.13#104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

christyjacob4 merged 2 commits intomainfromdev

Mar 10, 2025

Merged

fix: errors in typing for Python 3.13#104

christyjacob4 merged 2 commits intomainfromdev

Mar 10, 2025

Conversation

Copy link

Member

christyjacob4 commentedMar 10, 2025•
edited
Loading

What does this PR do?

In Python 3.13, list is now treated strictly as a built-in function, not a generic type hint. Python 3.13 introduces stricter type enforcement, causing conflicts whenlist[str] is used withoutfrom typing import List. Hence we get this error

Traceback (most recent call last):  File "/Users/christyjacob/opensource/christyjacob4/mcp-server-appwrite/.venv/bin/mcp-server-appwrite", line 4, in <module>    from mcp_server_appwrite.__main__ import main  File "/Users/christyjacob/opensource/christyjacob4/mcp-server-appwrite/src/mcp_server_appwrite/__init__.py", line 1, in <module>    from . import server  File "/Users/christyjacob/opensource/christyjacob4/mcp-server-appwrite/src/mcp_server_appwrite/server.py", line 11, in <module>    from appwrite.services.databases import Databases  File "/Users/christyjacob/opensource/christyjacob4/mcp-server-appwrite/.venv/lib/python3.13/site-packages/appwrite/services/databases.py", line 8, in <module>    class Databases(Service):    ...<1196 lines>...            }, api_params)  File "/Users/christyjacob/opensource/christyjacob4/mcp-server-appwrite/.venv/lib/python3.13/site-packages/appwrite/services/databases.py", line 108, in Databases    def list_collections(self, database_id: str, queries: list[str] = None, search: str = None):                                                          ~~~~^^^^^TypeError: 'function' object is not subscriptable

Hence we use theList that offers computability from Python 3.5+ to 3.13