- Notifications
You must be signed in to change notification settings - Fork65
feat: add types to parameters#103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
appwrite/client.py Outdated
| @@ -13,11 +13,11 @@ def __init__(self): | |||
| self._endpoint = 'https://cloud.appwrite.io/v1' | |||
| self._global_headers = { | |||
| 'content-type': '', | |||
| 'user-agent' : 'AppwritePythonSDK/8.0.0 (${os.uname().sysname}; ${os.uname().version}; ${os.uname().machine})', | |||
| 'user-agent' : 'AppwritePythonSDK/9.0.0 (${os.uname().sysname}; ${os.uname().version}; ${os.uname().machine})', | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Existing bug we need to fix, this should be an f-string it's not interpolating this 😬
| result = health.get_queue_stats_usage_dump( | ||
| threshold = None # optional | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
err should this endpoint be public?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
not really, but its part of the spec. In fact all the queue endpoints should be made hidden :/
Uh oh!
There was an error while loading.Please reload this page.
What does this PR do?
Fixes#43
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
Have you read theContributing Guidelines on issues?
(Write your answer here.)