- Notifications
You must be signed in to change notification settings - Fork135
Refactor Client.call() to use middlewares#145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:feat-offline-support-refactor
Are you sure you want to change the base?
Refactor Client.call() to use middlewares#145
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Previously, we added various caching metadata in the services andpassed those to the Client so that the Client knew where to cache thedata. This was a little messy and decentralized the offline supportcode.By adding a router, we can match against the path the Client receivesand determine where to cache the data.
| @@ -0,0 +1,80 @@ | |||
| final routes = [ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I was thinking this could be generated by the SDK generator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Well, i'm okay with generating by SDK generator if that is easier than hardcoding.
What does this PR do?
Break apart
Client.call()using middlewares.Test Plan
Manual
Related PRs and Issues
Have you read theContributing Guidelines on issues?
Yes