Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Ask users to have backups before installing the new version and fix cap letter.#9917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
DH-555 wants to merge1 commit intoappwrite:main
base:main
Choose a base branch
Loading
fromDH-555:patch-10

Conversation

DH-555
Copy link
Member

@DH-555DH-555 commentedMay 27, 2025•
edited by coderabbitaibot
Loading

The previous message is being understood like appwrite performing backups by default prior to installing the next version.
However this is not true and only the docker compose file is being backed-up.

This way people makes sure to have a backup prior to upgrading and prevents them from breaking things.

Also the Y letter is capitalized, but it's not the default option. Toggled it to N.

Summary by CodeRabbit

  • Style
    • Updated the confirmation prompt message when a previous installation is detected to clarify backup responsibilities and changed the default answer to "No" for improved user guidance.

@coderabbitaicoderabbitai
Copy link

coderabbitaibot commentedMay 27, 2025•
edited
Loading

Walkthrough

The confirmation prompt displayed during the installation process has been revised. The new message clarifies that users should ensure backups themselves before overwriting a previous installation, and the default answer is now set to "No" instead of "Yes." The underlying logic for handling user input remains unchanged.

Changes

File(s)Change Summary
src/Appwrite/Platform/Tasks/Install.phpUpdated the confirmation prompt message and default answer for overwriting a previous installation.

Poem

A prompt now speaks with caution clear,
"Back up your files before you steer!"
No longer "Yes" by default's hand,
It asks you gently where you stand.
So rabbits hop with backup cheer,
And overwrites hold less to fear!

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and betweena68d49a and9927392.

📒 Files selected for processing (1)
  • src/Appwrite/Platform/Tasks/Install.php (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: scan
🔇 Additional comments (1)
src/Appwrite/Platform/Tasks/Install.php (1)

65-65:Excellent improvement for user safety and clarity!

This change addresses a critical UX issue by:

  1. Removing misleading information - The previous message incorrectly implied comprehensive backups when only configuration files are actually backed up
  2. Improving safety - Changing the default from "Y" to "N" requires explicit user confirmation, preventing accidental data loss
  3. Clear guidance - The new message explicitly advises users to ensure they have backups, promoting responsible upgrade practices

The logic on line 67 remains correctly consistent with the new prompt format, and this change aligns perfectly with the PR objectives of preventing upgrade-related problems through better user awareness.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat withCodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag@coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag@coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on oursupport page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings togenerate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add@coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add@coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add@coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit ourDocumentation for detailed information on how to use CodeRabbit.
  • Join ourDiscord Community to get help, request features, and share feedback.
  • Follow us onX/Twitter for updates and announcements.

@DH-555DH-555 requested a review fromCopilotMay 27, 2025 19:10
Copy link

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR updates the confirmation message during installation to clarify that no automatic backup is performed, and it corrects the capitalization for the default input.

  • Clarifies that users must ensure they have their own backups.
  • Changes the default selection indicator from Y to N.

@github-actionsGitHub Actions
Copy link

Security Scan Results for PR

Docker Image Scan Results

PackageVersionVulnerabilitySeverity
binutils2.42-r0CVE-2025-0840HIGH
libexpat2.6.4-r0CVE-2024-8176HIGH
libxml22.12.7-r0CVE-2024-56171HIGH
libxml22.12.7-r0CVE-2025-24928HIGH
libxml22.12.7-r0CVE-2025-27113HIGH
libxml22.12.7-r0CVE-2025-32414HIGH
libxml22.12.7-r0CVE-2025-32415HIGH
sqlite-libs3.45.3-r1CVE-2025-29087HIGH
xz5.6.2-r0CVE-2025-31115HIGH
xz-libs5.6.2-r0CVE-2025-31115HIGH
golang.org/x/cryptov0.31.0CVE-2025-22869HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@DH-555
[8]ページ先頭
©2009-2025 Movatter.jp