- Notifications
You must be signed in to change notification settings - Fork4.6k
fix: Update es.json to resolve{{name}}
bug#9889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
coderabbitaibot commentedMay 25, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
WalkthroughThe Spanish localization file was updated to change the placeholder variable in the greeting lines of verification and password recovery email templates from "{{name}}" to "{{user}}". No other keys or text were modified. Changes
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat withCodeRabbit:
SupportNeed help? Create a ticket on oursupport page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
app/config/locale/translations/es.json (2)
7-7
:Placeholder updated to{{user}}
in verification email template
The Spanish translation now correctly uses the{{user}}
variable as per Appwrite’s email template syntax.Consider removing the extra period before the comma to improve punctuation consistency:
-"emails.verification.hello": "Hola, {{user}}.,"+"emails.verification.hello": "Hola, {{user}},"
19-19
:Placeholder updated to{{user}}
in recovery email template
This change aligns with the official template variable specification.As a minor refinement, you may also remove the redundant period before the comma for correct Spanish punctuation:
-"emails.recovery.hello": "Hola, {{user}}.,"+"emails.recovery.hello": "Hola, {{user}},"
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
app/config/locale/translations/es.json
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: scan
github-actionsbot commentedMay 25, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Security Scan Results for PRDocker Image Scan Results
Source Code Scan Results🎉 No vulnerabilities found! |
Uh oh!
There was an error while loading.Please reload this page.
What does this PR do?
Fix Spanish bug where the user was not properly rendered, showing '{{name}}' instead of '{{user}}' as specified in thedocumentation.
Checklist
Summary by CodeRabbit