Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: Made changes to support datasources configuration page for workspace#41324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
tomjose92 wants to merge14 commits intorelease
base:release
Choose a base branch
Loading
fromfeat/issue-35669/workspace-datasources
Open
Show file tree
Hide file tree
Changes from1 commit
Commits
Show all changes
14 commits
Select commitHold shift + click to select a range
228474d
Made changes to support datasources configuration page for workspaces…
tomjose92Oct 27, 2025
ad664c8
Fixed build error.
tomjose92Oct 27, 2025
e4c0ba2
Made fix to support /datasource/NEW. Also fixed the datasource url fo…
tomjose92Oct 27, 2025
5aa777b
Moved workspace datasource routes to constant values and using it in …
tomjose92Oct 28, 2025
1a30e1b
Added empty div inside IDERight styled component.
tomjose92Oct 29, 2025
3f3d190
On clicking the workspace name from Editor or Workspace Datasources p…
tomjose92Oct 29, 2025
9698179
Removed number of queries from under the Datasource name.
tomjose92Nov 10, 2025
ca19f3f
Modified hasCreateDSActionPermissionInApp to check if IDE Type is a w…
tomjose92Nov 11, 2025
aacb669
Updated the workspaceIDE to use takeLatest in the ee file. Moved work…
tomjose92Nov 11, 2025
547f3f7
Reusing the CreateNewDatasourceTab component directly in WorkspaceDat…
tomjose92Nov 11, 2025
7582821
Updated workspace page index to use render for WorkspaceDatasourcesPa…
tomjose92Nov 20, 2025
385b5e0
Showing DatasourceBlankState when there are no datasources available.…
tomjose92Nov 29, 2025
af290de
Removed commenting out of other test cases. Fixed lint issues.
tomjose92Nov 29, 2025
9caf3ed
Fixed linting and prettier issues for WorkspaceDatasourceSettings_spe…
tomjose92Nov 29, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
Made fix to support /datasource/NEW. Also fixed the datasource url fo…
…r datasource configuration
  • Loading branch information
@tomjose92
tomjose92 committedOct 27, 2025
commite4c0ba2a69df9d51268a3ceca732417708b0cede

Some comments aren't visible on the classic Files Changed page.

2 changes: 1 addition & 1 deletionapp/client/src/ce/RouteBuilder.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -203,7 +203,7 @@ export const workspaceDatasourcesURL = (workspaceId: string): string =>
export const workspaceDatasourceEditorURL = (
workspaceId: string,
datasourceId: string,
): string => `/workspace/${workspaceId}/datasources/${datasourceId}`;
): string => `/workspace/${workspaceId}/datasource/${datasourceId}`;

export const appLibrariesURL = (): string =>
urlBuilder.build({
Expand Down
14 changes: 6 additions & 8 deletionsapp/client/src/ce/entities/URLRedirect/URLAssembly.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -338,16 +338,16 @@ export class URLBuilder {

const entityId = this.resolveEntityId(builderParams);

// Handle workspace-specific suffix modification
let modifiedSuffix = suffix;
// Handle workspace-specific URL generation
let basePath = this.generateBasePath(entityId, mode);
let suffixPath = suffix ? `/${suffix}` : "";

if (this.isWorkspaceContext() && suffix?.startsWith("datasource/")) {
// For workspace context, remove the 'datasource/' prefix from suffix
modifiedSuffix = suffix.replace("datasource/", "");
// For workspace datasource URLs, use singular /datasource path
basePath = `/workspace/${entityId}/datasource`;
suffixPath = `/${suffix.replace("datasource/", "")}`;
}

const basePath = this.generateBasePath(entityId, mode);

const queryParamsToPersist = fetchQueryParamsToPersist(
persistExistingParams,
);
Expand All@@ -362,8 +362,6 @@ export class URLBuilder {

const queryString = getQueryStringfromObject(modifiedQueryParams);

const suffixPath = modifiedSuffix ? `/${modifiedSuffix}` : "";

const hashPath = hash ? `#${hash}` : "";

// hash fragment should be at the end of the href
Expand Down
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -119,21 +119,19 @@ export const WorkspaceDatasourcesPage = (
{/* Create new datasource - use the exact same component */}
<SentryRoute
exact
path="/workspace/:workspaceId/datasources/new"
path="/workspace/:workspaceId/datasources/NEW"
render={() => <WorkspaceCreateNewDatasourceTab />}
/>
{/* Edit existing datasource - use workspace-specific editor */}
<SentryRoute
exact
path="/workspace/:workspaceId/datasources/:datasourceId"
path="/workspace/:workspaceId/datasource/:datasourceId"
render={() => <WorkspaceDatasourceEditor />}
/>
{/* Default list view - show "Connect a datasource" page by default */}
<SentryRoute
path="/workspace/:workspaceId/datasources"
render={() => (
<WorkspaceCreateNewDatasourceTab workspaceId={workspaceId} />
)}
render={() => <WorkspaceCreateNewDatasourceTab />}
/>
</Switch>
</MainPane>
Expand Down
10 changes: 10 additions & 0 deletionsapp/client/src/pages/workspace/index.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,16 @@ export function Workspace() {
)}
path={`${path}/:workspaceId/datasources`}
/>
<SentryRoute
component={({
match,
}: {
match: { params: { workspaceId: string } };
}) => (
<WorkspaceDatasourcesPage workspaceId={match.params.workspaceId} />
)}
path={`${path}/:workspaceId/datasource`}
/>
<SentryRoute component={DefaultWorkspacePage} />
</Switch>
</PageWrapper>
Expand Down
Loading

[8]ページ先頭

©2009-2025 Movatter.jp