- Notifications
You must be signed in to change notification settings - Fork4.4k
feat: Made changes to support datasources configuration page for workspace#41324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
tomjose92 wants to merge14 commits intoreleaseChoose a base branch fromfeat/issue-35669/workspace-datasources
base:release
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+981 −16
Open
Changes from1 commit
Commits
Show all changes
14 commits Select commitHold shift + click to select a range
228474d Made changes to support datasources configuration page for workspaces…
tomjose92ad664c8 Fixed build error.
tomjose92e4c0ba2 Made fix to support /datasource/NEW. Also fixed the datasource url fo…
tomjose925aa777b Moved workspace datasource routes to constant values and using it in …
tomjose921a30e1b Added empty div inside IDERight styled component.
tomjose923f3d190 On clicking the workspace name from Editor or Workspace Datasources p…
tomjose929698179 Removed number of queries from under the Datasource name.
tomjose92ca19f3f Modified hasCreateDSActionPermissionInApp to check if IDE Type is a w…
tomjose92aacb669 Updated the workspaceIDE to use takeLatest in the ee file. Moved work…
tomjose92547f3f7 Reusing the CreateNewDatasourceTab component directly in WorkspaceDat…
tomjose927582821 Updated workspace page index to use render for WorkspaceDatasourcesPa…
tomjose92385b5e0 Showing DatasourceBlankState when there are no datasources available.…
tomjose92af290de Removed commenting out of other test cases. Fixed lint issues.
tomjose929caf3ed Fixed linting and prettier issues for WorkspaceDatasourceSettings_spe…
tomjose92File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Made fix to support /datasource/NEW. Also fixed the datasource url fo…
…r datasource configuration
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commite4c0ba2a69df9d51268a3ceca732417708b0cede
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
2 changes: 1 addition & 1 deletionapp/client/src/ce/RouteBuilder.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
14 changes: 6 additions & 8 deletionsapp/client/src/ce/entities/URLRedirect/URLAssembly.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
8 changes: 3 additions & 5 deletionsapp/client/src/pages/workspace/WorkspaceDatasourcesPage.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletionsapp/client/src/pages/workspace/index.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.