Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: tooltip position on edge of screen#34518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
admirhusic wants to merge3 commits intoappsmithorg:release
base:release
Choose a base branch
Loading
fromadmirhusic:fix/tooltip-position-fix
Open
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -75,7 +75,13 @@ if (!portalContainer) {
function TooltipComponent(props: TooltipProps) {
const modifiers = useMemo(
() => ({
preventOverflow: { enabled: false },
preventOverflow: {
enabled: true,
boundariesElement: "viewport",
},
flip: {
enabled: true,
},
Comment on lines +78 to +84
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Consider Adding Comments for Clarity

While the code changes are effective, adding comments explaining why these specific modifiers were chosen could be beneficial for future maintenance. This is especially important as tooltips are a common UI component and these changes might have nuanced impacts on different parts of the application.

      preventOverflow: {+       // Enable to prevent the tooltip from overflowing the viewport        enabled: true,+       // Set the boundary element to the viewport to ensure visibility        boundariesElement: "viewport",      },      flip: {+       // Enable flipping to adjust tooltip position dynamically        enabled: true,      },
Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
preventOverflow:{
enabled:true,
boundariesElement:"viewport",
},
flip:{
enabled:true,
},
preventOverflow:{
// Enable to prevent the tooltip from overflowing the viewport
enabled:true,
// Set the boundary element to the viewport to ensure visibility
boundariesElement:"viewport",
},
flip:{
// Enable flipping to adjust tooltip position dynamically
enabled:true,
},

...props.modifiers,
}),
[props.modifiers],
Expand Down
[8]ページ先頭
©2009-2025 Movatter.jp