cc@benlangmuir

@swift-ci please test

The build errors here and in#288 look unrelated:

clang-tools-extra/clangd/index/IndexAction.cpp:148:19: error: no member named 'createIndexingASTConsumer' in namespace 'clang::index'

However on linux there are compile warnings I should fix:

llvm/tools/clang/include/indexstore/indexstore.h:289:9: warning: 'flag_enum' attribute ignored [-Wignored-attributes]typedef INDEXSTORE_OPTIONS(uint64_t, indexstore_symbol_property_t) {        ^llvm/tools/clang/include/indexstore/indexstore.h:102:48: note: expanded from macro 'INDEXSTORE_OPTIONS'# define INDEXSTORE_OPTIONS(_type, _name) enum INDEXSTORE_OPTIONS_ATTRS _name : _type _name; enum INDEXSTORE_OPTIONS_ATTRS _name : _type                                               ^

@jkorous-apple do you recognize the error aboutcreateIndexingASTConsumer that@kastiglione mentioned?

createIndexingASTConsumer is part of the refactoring that Dmitri landed upstream last week.

commit 8d32053f113348a4ea94f59b7553733aff0ba651
Author: Dmitri Gribenkogribozavr@gmail.com
Date: Thu Aug 29 11:43:05 2019 +0000

[Index] Stopped wrapping FrontendActions in libIndex and its usersExposed a new function, createIndexingASTConsumer, that creates anASTConsumer. ASTConsumers compose well.

Is the target branch correct?

If it was last week, maybe I should rebase?

I've rebased both PRs.

Should this be closed now?apple/stable/20190619 was last updated in July?

Should this be closed now? apple/stable/20190619 was last updated in July?

You're looking at the original (author) date of the commit, but it was only just recently cherry-picked to this branch. If you usegit log --format=fuller you can see when the cherry-pick happened:

AuthorDate: Thu Jul 11 22:59:28 2019
CommitDate: Thu Oct 3 14:01:33 2019

@swift-ci please test

Thanks, I was actually looking at GitHub, but I'll know better now that it shows author date.

@swift-ci please test Linux

sweet things passed