- Notifications
You must be signed in to change notification settings - Fork400
feat: Persist RequestList state#1274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -34,7 +34,7 @@ def __init__( | |||
| *, | |||
| default_state: TStateModel, | |||
| persist_state_key: str, | |||
| persistence_enabled:bool = False, | |||
| persistence_enabled:Literal[True, False, 'explicit_only'] = False, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could you please describe how this is different from True? Probably this should also be explained in the docstring in the argument description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good
| next_index: Annotated[int, Field(alias='nextIndex')] = 0 | ||
| next_unique_key: Annotated[str | None, Field(alias='nextUniqueKey')] = None | ||
| in_progress: Annotated[set[str], Field(alias='inProgress')] = set() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Are thecamelCase aliases necessary? AFAIK I also did not use them in FS storage clients.
RequestList#99