apify/apify-sdk-pythonPublic

NotificationsYou must be signed in to change notification settings
Fork12
Star134

chore: utilize`ensure_context` decorator for Actor#400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

vdusek wants to merge2 commits intomaster

base:master

Choose a base branch

fromadd-ensure-context

Open

chore: utilize`ensure_context` decorator for Actor#400

vdusek wants to merge2 commits intomasterfromadd-ensure-context

Conversation

Copy link

Contributor

vdusek commentedFeb 13, 2025

Utilizeensure_context decorator from Crawlee rather than callingraise_if_... method in the Actor class.

chore: utilizeensure_context decorator for Actor

01ed402

vdusek added adhoc

Ad-hoc unplanned task added during the sprint.

debt

Code quality improvement or decrease of technical debt.

t-toolingIssues with this label are in the ownership of the tooling team. labels

Feb 13, 2025

vdusek added this to the108th sprint - Tooling team milestone

Feb 13, 2025

vdusek requested review fromjanbuchar andPijukatel

February 13, 2025 09:16

vdusek self-assigned this

Feb 13, 2025

vdusek marked this pull request as ready for review

February 13, 2025 09:16

vdusek removed request forjanbuchar andPijukatel

February 13, 2025 09:17

vdusek marked this pull request as draft

February 13, 2025 09:17

fix tests

c6a1142

github-actionsbot added the testedTemporary label used only programatically for some analytics. label

Feb 13, 2025

vdusek marked this pull request as ready for review

February 13, 2025 09:25

vdusek requested review fromjanbuchar andPijukatel

February 13, 2025 09:26

janbuchar reviewed

Feb 13, 2025

View reviewed changes

Copy link

Contributor

janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm honestly not sure about this. It reduces some duplication, yes, but the error message will be pretty cryptic. It is fine for an internal helper in Crawlee, but here, it's very much user-facing. Maybe we could make a wrapper for the decorator?

Copy link

ContributorAuthor

vdusek commentedFeb 13, 2025

Error message:

RuntimeError: The _ActorType is not active. Use it within the async context.

Whole traceback:

>>> asyncio.run(Actor.reboot())Traceback (most recent call last):  File "<python-input-5>", line 1, in <module>    asyncio.run(Actor.reboot())    ~~~~~~~~~~~^^^^^^^^^^^^^^^^  File "/usr/lib64/python3.13/asyncio/runners.py", line 195, in run    return runner.run(main)           ~~~~~~~~~~^^^^^^  File "/usr/lib64/python3.13/asyncio/runners.py", line 118, in run    return self._loop.run_until_complete(task)           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^  File "/usr/lib64/python3.13/asyncio/base_events.py", line 725, in run_until_complete    return future.result()           ~~~~~~~~~~~~~^^  File "/home/vdusek/Projects/apify-sdk-python/.venv/lib/python3.13/site-packages/crawlee/_utils/context.py", line 36, in async_wrapper    raise RuntimeError(f'The {self.__class__.__name__} is not active. Use it within the async context.')RuntimeError: The _ActorType is not active. Use it within the async context.

Is it that bad? We can wrap it of course.

Copy link

Contributor

janbuchar commentedFeb 13, 2025•
edited
Loading

Is it that bad? We can wrap it of course.

Well, leaking the existence of_ActorType is confusing by itself. Plus, the message should tell the user "Just useActor.init orasync with Actor" - many of them won't even know what a context manager is.