NotificationsYou must be signed in to change notification settings
Fork225
Star313

fix: implement admin permissions#429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

vincentchalamon wants to merge3 commits into4.0

base:4.0

Choose a base branch

fromfix/admin-permissions

Draft

fix: implement admin permissions#429

vincentchalamon wants to merge3 commits into4.0fromfix/admin-permissions

Conversation

Copy link

Contributor

vincentchalamon commentedJul 12, 2024•
edited
Loading

Fixes#427

fix: implement admin permissions

0d035df

vincentchalamon mentioned this pull request

Jul 12, 2024

Admin authentication problems#427

Open

fzaninotto reviewed

Jul 12, 2024

View reviewed changes

pwa/components/admin/Admin.tsx Outdated

		constAdminWithOIDC=()=>{
		// Can't use next-auth/middleware because of https://github.com/nextauthjs/next-auth/discussions/7488
		const{data:session, status}=useSession();
		const{ permissions}=usePermissions();

Copy link

Contributor

fzaninottoJul 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

usePermissions can only be called by children of react-admin's<Admin> component (otherwise there is no AuthProviderContext and QueryClientContext available). That's why you have an error.

The proper fix would be to call theusePermissions inBookList and other admin-only components, and redirect to a/forbidden CustomRoute if the permissions don't match.