Commit0236af6

committed

fix getGCD return wrong answer when max(a, b) exceeds magnitude of precision determined by p

1 parent0e7addc commit0236af6Copy full SHA for 0236af6

File tree

-4

lines changed

-4

lines changed

Lines changed: 8 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -390,16 +390,20 @@ class Utils {`
`390`	`390`	`// Find the Greatest Common Divisor of two numbers`
`391`	`391`	`//`
`392`	`392`	`staticgetGCD(a,b,p=7){`
`393`		`-letbig=Math.pow(10,p-Math.floor(Math.log10(Math.max(a,b))))`
`394`		`-a=Math.round(Math.abs(a)*big)`
`395`		`-b=Math.round(Math.abs(b)*big)`
	`393`	`+letfactor=Math.pow(10,p-Math.floor(Math.log10(Math.max(a,b))))`
	`394`	`+if(factor>1){`
	`395`	`+a=Math.round(Math.abs(a)*factor)`
	`396`	`+b=Math.round(Math.abs(b)*factor)`
	`397`	`+}else{`
	`398`	`+factor=1`
	`399`	`+}`
`396`	`400`
`397`	`401`	`while(b){`
`398`	`402`	`lett=b`
`399`	`403`	`b=a%b`
`400`	`404`	`a=t`
`401`	`405`	`}`
`402`		`-returna/big`
	`406`	`+returna/factor`
`403`	`407`	`}`
`404`	`408`
`405`	`409`	`staticgetPrimeFactors(n){`

Comments

(0)