- Notifications
You must be signed in to change notification settings - Fork16.7k
Comments
fix(echarts): correct time shift handling in Timeseries transformProps#38126
Open
YousufFFFF wants to merge 1 commit intoapache:masterfrom
Open
fix(echarts): correct time shift handling in Timeseries transformProps#38126YousufFFFF wants to merge 1 commit intoapache:masterfrom
YousufFFFF wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
bito-code-reviewbot commentedFeb 20, 2026 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Code Review Agent Run #1b0812Actionable Suggestions - 0Additional Suggestions - 1
Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to thedocumentation for additional commands. Configuration This repository uses Documentation & Help |
✅ Deploy Preview forsuperset-docs-preview ready!
To edit notification comments on pull requests, go to yourNetlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes incorrect time shift behavior in the ECharts Timeseries path used by the Bar chart.
Fixes#36966.
Previously, when a time shift (e.g., 1 month, 5 months) was applied, the shifted series was not properly aligned during series construction inside
transformProps.ts. This caused incorrect rendering and misalignment of shifted data along the x-axis.This update corrects the time shift handling logic to ensure proper timestamp alignment and consistent rendering across different shift values and dimension combinations.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before (Time Shift Not Functioning Correctly)
After (Time Shift Working as Expected)
Base.Test.-.Google.Chrome.2026-02-20.23-36-29.mp4
TESTING INSTRUCTIONS
1 month,5 months)Tested locally using Docker environment.
ADDITIONAL INFORMATION