Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Comments

feat: Persist default folders location when repositioned in folders editor#38105

Open
kgabryje wants to merge 6 commits intoapache:masterfrom
kgabryje:folders/default-folder-persisting
Open

feat: Persist default folders location when repositioned in folders editor#38105
kgabryje wants to merge 6 commits intoapache:masterfrom
kgabryje:folders/default-folder-persisting

Conversation

@kgabryje
Copy link
Member

SUMMARY

Previously, the default Metrics and Columns folders were stripped before saving and recreated on load, which meant their position relative to custom folders was lost. This change persists default folders so their ordering is preserved across saves.
Unassigned metrics/columns (e.g., newly added after last save) are now appended to existing default folders rather than creating duplicate fallback folders.
Also includes a fix for calculated columns, which were not appearing in folders editor

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

  1. EnableDATASET_FOLDERS ff
  2. Open the dataset editor with folders enabled
  3. Create a custom folder and drag it between the default Metrics and Columns folders
  4. Save the dataset
  5. Verify that the order is persisted in the datasource panel in Explore
  6. Verify that the order is persisted in the folders editor
  7. Add a new metric or column to the dataset, reopen folders, and verify it appears in the appropriate default folder

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process inSIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@bito-code-review
Copy link
Contributor

bito-code-reviewbot commentedFeb 19, 2026•
edited
Loading

Code Review Agent Run #d37b1c

Actionable Suggestions - 0
Additional Suggestions - 1
  • superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.tsx -1
    • Incorrect folder count logic ·Line 915-920
      The folderCount calculation incorrectly handles cases where only some default folders are saved. Using `some()` to check for any default folder presence and adding 0 if found leads to an undercount when exactly one default folder is saved (e.g., adds 0 instead of 1). This could cause UI display issues with folder counts. The fix counts saved defaults precisely and adds only the missing ones.
      Code suggestion
       @@ -915,6 +915,6 @@-        folderCount: (() => {-          const savedFolders = props.datasource.folders || [];-          const savedCount = countAllFolders(savedFolders);-          const hasDefaultsSaved = savedFolders.some(f => isDefaultFolder(f.uuid));-          return savedCount + (hasDefaultsSaved ? 0 : DEFAULT_FOLDERS_COUNT);-        })(),+        folderCount: (() => {+          const savedFolders = props.datasource.folders || [];+          const savedCount = countAllFolders(savedFolders);+          const savedDefaultsCount = savedFolders.filter(f => isDefaultFolder(f.uuid)).length;+          return savedCount + (DEFAULT_FOLDERS_COUNT - savedDefaultsCount);+        })(),
Review Details
  • Files reviewed -7 · Commit Range:a62fb68..a62fb68
    • superset-frontend/src/components/Datasource/FoldersEditor/folderOperations.test.ts
    • superset-frontend/src/components/Datasource/FoldersEditor/folderOperations.ts
    • superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.tsx
    • superset-frontend/src/explore/components/DatasourcePanel/transformDatasourceFolders.test.ts
    • superset-frontend/src/explore/components/DatasourcePanel/transformDatasourceFolders.ts
    • superset/commands/dataset/update.py
    • tests/unit_tests/commands/dataset/update_test.py
  • Files skipped -0
    • Tools
      • Whispers (Secret Scanner) - ✔︎ Successful
      • Detect-secrets (Secret Scanner) - ✔︎ Successful
      • Eslint (Linter) - ✔︎ Successful
      • MyPy (Static Code Analysis) - ✔︎ Successful
      • Astral Ruff (Static Code Analysis) - ✔︎ Successful
    Bito Usage Guide

    Commands

    Type the following command in the pull request comment and save the comment.

    • /review - Manually triggers a full AI review.

    • /pause - Pauses automatic reviews on this pull request.

    • /resume - Resumes automatic reviews.

    • /resolve - Marks all Bito-posted review comments as resolved.

    • /abort - Cancels all in-progress reviews.

    Refer to thedocumentation for additional commands.

    Configuration

    This repository usesSuperset You can customize the agent settingshere or contact your Bito workspace admin atevan@preset.io.

    Documentation & Help

    AI Code Review powered byBito Logo

    @dosubotdosubotbot added the data:datasetRelated to dataset configurations labelFeb 19, 2026
    kgabryjeand others added3 commitsFebruary 19, 2026 18:14
    Simplify test_validate_folders_allows_default_folders to use emptychildren arrays, avoiding UUID string vs object type mismatch thatcaused the test to fail.Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
    Add `as const` assertions to FoldersEditorItemType.Folder in inlinetest objects so TypeScript narrows the type correctly.Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
    @codecov
    Copy link

    codecovbot commentedFeb 19, 2026•
    edited
    Loading

    Codecov Report

    ❌ Patch coverage is60.00000% with2 lines in your changes missing coverage. Please review.
    ✅ Project coverage is 66.44%. Comparing base (76d897e) to head (8920bca).
    ⚠️ Report is 3800 commits behind head on master.

    Files with missing linesPatch %Lines
    superset/commands/dataset/update.py60.00%0 Missing and 2 partials⚠️
    Additional details and impacted files
    @@            Coverage Diff             @@##           master   #38105      +/-   ##==========================================+ Coverage   60.48%   66.44%   +5.96%==========================================  Files        1931      668    -1263       Lines       76236    51394   -24842       Branches     8568     5794    -2774     ==========================================- Hits        46114    34151   -11963+ Misses      28017    15855   -12162+ Partials     2105     1388     -717
    FlagCoverage Δ
    hive41.43% <60.00%> (-7.72%)⬇️
    javascript?
    mysql64.55% <60.00%> (?)
    postgres64.63% <60.00%> (?)
    presto41.45% <60.00%> (-12.35%)⬇️
    python66.42% <60.00%> (+2.91%)⬆️
    sqlite64.22% <60.00%> (?)
    unit100.00% <ø> (+42.36%)⬆️

    Flags with carried forward coverage won't be shown.Click here to find out more.

    ☔ View full report in Codecov by Sentry.
    📢 Have feedback on the report?Share it here.

    🚀 New features to boost your workflow:
    • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
    • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

    @bito-code-review
    Copy link
    Contributor

    bito-code-reviewbot commentedFeb 19, 2026•
    edited
    Loading

    Code Review Agent Run #61053e

    Actionable Suggestions - 0
    Review Details
    • Files reviewed -7 · Commit Range:a62fb68..20e7d0c
      • superset-frontend/src/components/Datasource/FoldersEditor/folderOperations.test.ts
      • superset-frontend/src/components/Datasource/FoldersEditor/folderOperations.ts
      • superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.tsx
      • superset-frontend/src/explore/components/DatasourcePanel/transformDatasourceFolders.test.ts
      • superset-frontend/src/explore/components/DatasourcePanel/transformDatasourceFolders.ts
      • superset/commands/dataset/update.py
      • tests/unit_tests/commands/dataset/update_test.py
    • Files skipped -0
      • Tools
        • Whispers (Secret Scanner) - ✔︎ Successful
        • Detect-secrets (Secret Scanner) - ✔︎ Successful
        • Eslint (Linter) - ✔︎ Successful
        • MyPy (Static Code Analysis) - ✔︎ Successful
        • Astral Ruff (Static Code Analysis) - ✔︎ Successful
      Bito Usage Guide

      Commands

      Type the following command in the pull request comment and save the comment.

      • /review - Manually triggers a full AI review.

      • /pause - Pauses automatic reviews on this pull request.

      • /resume - Resumes automatic reviews.

      • /resolve - Marks all Bito-posted review comments as resolved.

      • /abort - Cancels all in-progress reviews.

      Refer to thedocumentation for additional commands.

      Configuration

      This repository usesSuperset You can customize the agent settingshere or contact your Bito workspace admin atevan@preset.io.

      Documentation & Help

      AI Code Review powered byBito Logo

      @bito-code-review
      Copy link
      Contributor

      bito-code-reviewbot commentedFeb 19, 2026•
      edited
      Loading

      Code Review Agent Run #29e4ca

      Actionable Suggestions - 0
      Review Details
      • Files reviewed -7 · Commit Range:20e7d0c..8920bca
        • superset-frontend/src/components/Datasource/FoldersEditor/folderOperations.test.ts
        • superset-frontend/src/components/Datasource/FoldersEditor/folderOperations.ts
        • superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.tsx
        • superset-frontend/src/explore/components/DatasourcePanel/transformDatasourceFolders.test.ts
        • superset-frontend/src/explore/components/DatasourcePanel/transformDatasourceFolders.ts
        • superset/commands/dataset/update.py
        • tests/unit_tests/commands/dataset/update_test.py
      • Files skipped -0
        • Tools
          • Eslint (Linter) - ✔︎ Successful
          • Whispers (Secret Scanner) - ✔︎ Successful
          • Detect-secrets (Secret Scanner) - ✔︎ Successful
        Bito Usage Guide

        Commands

        Type the following command in the pull request comment and save the comment.

        • /review - Manually triggers a full AI review.

        • /pause - Pauses automatic reviews on this pull request.

        • /resume - Resumes automatic reviews.

        • /resolve - Marks all Bito-posted review comments as resolved.

        • /abort - Cancels all in-progress reviews.

        Refer to thedocumentation for additional commands.

        Configuration

        This repository usesSuperset You can customize the agent settingshere or contact your Bito workspace admin atevan@preset.io.

        Documentation & Help

        AI Code Review powered byBito Logo

        Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

        Reviewers

        @betodealmeidabetodealmeidaAwaiting requested review from betodealmeida

        @Antonio-RiveroMartnezAntonio-RiveroMartnezAwaiting requested review from Antonio-RiveroMartnez

        At least 1 approving review is required to merge this pull request.

        Assignees

        No one assigned

        Labels

        data:datasetRelated to dataset configurationssize/L

        Projects

        None yet

        Milestone

        No milestone

        Development

        Successfully merging this pull request may close these issues.

        1 participant

        @kgabryje
        [8]ページ先頭
        ©2009-2026 Movatter.jp