- Notifications
You must be signed in to change notification settings - Fork12k
Add some comments to module proxy, No code change#9856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
winglechen wants to merge8 commits intoapache:developChoose a base branch fromwolforest:comment-251116
base:develop
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+86 −1
Open
Changes from1 commit
Commits
Show all changes
8 commits Select commitHold shift + click to select a range
7d2c4a3 docs: add comments to class GrpcMessagingApplication
winglechen2da77dc Merge branch 'apache:develop' into comment
winglechen906a88b Merge branch 'apache:develop' into comment
winglechen11597bb Merge branch 'apache:develop' into comment
winglechen034db71 Merge branch 'apache:develop' into comment
winglechen512bc80 comment: add comments to ProxyStartup
winglechena0cac85 comment: add comments to remoting related thread pool config of Proxy…
winglechen1ecc3a0 Merge branch 'apache:develop' into comment
winglechenFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
comment: add comments to ProxyStartup
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit512bc80c1d2847997fc8010c8cd1cb7a88f68986
There are no files selected for viewing
10 changes: 10 additions & 0 deletionsproxy/src/main/java/org/apache/rocketmq/proxy/ProxyStartup.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.