- Notifications
You must be signed in to change notification settings - Fork12k
Removed unnecessary class casts#9844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
TheRealHaui wants to merge5 commits intoapache:developChoose a base branch
base:develop
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Removed unnecessary class casts#9844
TheRealHaui wants to merge5 commits intoapache:developfromTheRealHaui:remove-unnecessary-class-casts
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
codecov-commenter commentedNov 11, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## develop #9844 +/- ##=============================================- Coverage 48.35% 48.27% -0.08%+ Complexity 12263 12240 -23============================================= Files 1314 1314 Lines 93799 93799 Branches 12036 12036 =============================================- Hits 45352 45283 -69- Misses 42841 42898 +57- Partials 5606 5618 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…into remove-unnecessary-class-casts# Conflicts:#common/src/test/java/org/apache/rocketmq/common/filter/impl/PolishExprTest.java
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unnecessary class casts removed.