Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added some new tests#9823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
TheRealHaui wants to merge1 commit intoapache:develop
base:develop
Choose a base branch
Loading
fromTheRealHaui:add-some-tests

Conversation

@TheRealHaui
Copy link
Contributor

Added some new tests to increase test code coverage.

Copy link
Member

@lizhiminslizhimins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It is recommended to merge them into one; avoid using AI to generate low-quality use cases.

@TheRealHaui
Copy link
ContributorAuthor

@lizhimins,
if you want I can of course merge all the individual tests I added for the individual methods - CommandUtil.fetchBrokerNameByAddr, ...fetchMasterAndSlaveAddrByBrokerName, ...fetchMasterAddrByBrokerName and ...fetchMasterAndSlaveAddrByClusterName - into one big test method.
Most organizsations however prefer individual Unit Tests for their individual methods/units of code.
Further, this pattern is used in the code base for all pre-existing Unit Tests of the CommandUtil class too.
Aside of other already existing Unit Tests - e.g. in the DefaultMonitorListenerTest class.

The Unit Tests were not generated by any whatsoever AI!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lizhiminslizhiminslizhimins requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TheRealHaui@lizhimins

[8]ページ先頭

©2009-2025 Movatter.jp