- Notifications
You must be signed in to change notification settings - Fork12k
[ISSUE #9670]Simplify messageStore sendMessageBackHook assignment by removing null check#9671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
mxsm wants to merge1 commit intoapache:developChoose a base branch frommxsm:enh-mxsm1
base:develop
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…nt by removing null check
codecov-commenter commentedSep 5, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## develop #9671 +/- ##=============================================- Coverage 48.14% 48.01% -0.13%+ Complexity 12084 12054 -30============================================= Files 1313 1313 Lines 92839 92838 -1 Branches 11868 11867 -1 =============================================- Hits 44694 44577 -117- Misses 42638 42741 +103- Partials 5507 5520 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MemberAuthor
mxsm commentedSep 8, 2025
@RongtongJin cc |
RongtongJin approved these changesSep 9, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes#9670
Brief Description
How Did You Test This Change?