NotificationsYou must be signed in to change notification settings
Fork914
Star3k

More defensive guards against invalid code points in ant Preferences#8943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ebarboni merged 1 commit intoapache:deliveryfrommbien:ant-more-illegal-codepoint-mitigation

Oct 23, 2025

Merged

More defensive guards against invalid code points in ant Preferences#8943

ebarboni merged 1 commit intoapache:deliveryfrommbien:ant-more-illegal-codepoint-mitigation

Oct 23, 2025

Conversation

Copy link

Member

mbien commentedOct 21, 2025•
edited
Loading

followup on#6094

OncePreferences is loaded containingU+0000 in a key, it can't be used anymore since even removing that key (e.g via clear()) will throw IAE.

What we can do however is to remove and recreate the Preferences node.

example output with this change active:

WARNING [org.apache.tools.ant.module.api.IntrospectedInfo]: skipping malformed key; pref path: /org/apache/tools/ant/module/customDefs, msg: Key contains code point U+0000WARNING [org.apache.tools.ant.module.AntSettings]: recreating preferences node due to code point U+0000

tested by corrupting the config file using this script:

staticvoidmain()throwsjava.io.IOException {Stringpath ="netbeans/nbbuild/testuserdir/config/Preferences/org/apache/tools/ant/module/customDefs.properties";Files.writeString(Path.of(path),"\u0000",StandardOpenOption.APPEND        );    }

closes#8941
targets delivery

More defensive guards against invalid code points in ant Preferences

d13b33f

Once the Preferences is loaded containing U+0000 in a key, it can'tbe used anymore since even removing that key (e.g via clear()) willthrow IAE.What we can do however is to remove and recreate the Preferences node.

mbien added this to theNB28 milestone

Oct 21, 2025

mbien requested a review frommatthiasblaesing

October 21, 2025 07:12

mbien added the Ant[ci] enable "build tools" tests label

Oct 21, 2025

mbien linked an issue

Oct 21, 2025

that may beclosed by this pull request

am getting an Unexpected Exception when cleaning a Netbeans project; can't use Netbeans for app developement now.#8941

Closed

mbien requested a review fromlkishalmi