Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add missing CSS properties : margin-block, pading-block, scroll-behavior, conic-gradient, filter-effects#8790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@haidubogdan
Copy link
Contributor

@haidubogdanhaidubogdan commentedSep 4, 2025•
edited by matthiasblaesing
Loading

The following css style properties will be recognized :

  • backdrop-filter
  • conic-gradient
  • margin-block
  • padding-block/-start/-end
  • scroll-behavior/-start-/end
  • scroll-snap-align
  • scroll-snap-type
  • scroll-margin
  • scroll-padding

Example:
Before
image

After:
image

Closes:#7010

@troizettroizet added the CSS[ci] enable web job labelSep 5, 2025
@mbienmbien linked an issueSep 5, 2025 that may beclosed by this pull request
@mbienmbien added the ci:dev-build[ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labelSep 5, 2025
@mbienmbien added this to theNB28 milestoneSep 5, 2025
@apacheapache locked and limited conversation to collaboratorsSep 5, 2025
@apacheapache unlocked this conversationSep 5, 2025
Copy link
Contributor

@matthiasblaesingmatthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for the addition. I made a first pass over this and left a few inline comments.

@haidubogdanhaidubogdanforce-pushed thet_issue_7010_unknown_css_properties branch 7 times, most recently from3a7b787 todb42be1CompareSeptember 8, 2025 20:09
@haidubogdan
Copy link
ContributorAuthor

Thanks for the review, I think I'm beginning to better understand the properties structure.

Copy link
Contributor

@matthiasblaesingmatthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for the updates. I made a second pass and added some comments about necessary rearrangements. I hope that they make sense.

@haidubogdanhaidubogdanforce-pushed thet_issue_7010_unknown_css_properties branch 2 times, most recently from3779600 to92cf9b2CompareSeptember 25, 2025 19:58
@haidubogdan
Copy link
ContributorAuthor

haidubogdan commentedSep 25, 2025•
edited
Loading

@matthiasblaesing
I can't cover theStandardPropertiesHelpResolverTest by myself as it depends on the binarycss3-spec.zip which requires upload tohttp://netbeans.osuosl.org/binaries/
I've updated thecss3-spec-howtocreate.txt file, and tested the generated doc zip successfully on local, but that's the most I can do for the moment.

@haidubogdanhaidubogdanforce-pushed thet_issue_7010_unknown_css_properties branch from92cf9b2 to57f61dbCompareSeptember 25, 2025 20:08
@matthiasblaesing
Copy link
Contributor

matthiasblaesing commentedSep 26, 2025•
edited
Loading

@matthiasblaesing I can't cover theStandardPropertiesHelpResolverTest by myself as it depends on the binarycss3-spec.zip which requires upload tohttp://netbeans.osuosl.org/binaries/ I've updated thecss3-spec-howtocreate.txt file, and tested the generated doc zip successfully on local, but that's the most I can do for the moment.

I rebuild the css3-spec.zip with the updated instructions (please replace the https URL with a plain http one, so that it is consistent). You can use it by replacing the line in thebinaries-list like this:

FD81D87A20BB39C331599193E1CFBA0F64D4693E https://doppel-helix.eu/FD81D87A20BB39C331599193E1CFBA0F64D4693E-css3-spec.zip css3-spec.zip

The idea here is that thebinaries-list file has three different download routes:

  • download from maven central using maven coordinates as basis (preferred)
  • download from a stable public repository via URL - is also convenient for experiments/tests/staging as done here
  • download from netbeans.osuosl.org (fallback for legacy dependencies/exceptions)

Edit:

Of course experimental URLs need to be replace before integration.

@haidubogdan
Copy link
ContributorAuthor

99193E1CFBA0F64D4693E-css3-sp

Thank you@matthiasblaesing
Hopefully, these types of updates will be rare.

@matthiasblaesing
Copy link
Contributor

After the successful run in#8869 I uploaded the new binary. So please two updates:

  1. Update thebinaries-list entry toFD81D87A20BB39C331599193E1CFBA0F64D4693E css3-spec.zip
  2. Incss3-spec-howtocreate.txt replace thehttps URL with a plainhttp one. (line 59)

@haidubogdanhaidubogdanforce-pushed thet_issue_7010_unknown_css_properties branch 2 times, most recently fromcde2da6 toff76342CompareSeptember 28, 2025 10:08
@haidubogdan
Copy link
ContributorAuthor

After the successful run in#8869 I uploaded the new binary. So please two updates:

1. Update the `binaries-list` entry to `FD81D87A20BB39C331599193E1CFBA0F64D4693E css3-spec.zip`2. In `css3-spec-howtocreate.txt` replace the `https` URL with a plain `http` one. (line 59)

Nice,
I've pushed the updates.

Copy link
Contributor

@matthiasblaesingmatthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please update the binaries-list to the final location. The variant with my staging upload was never pushed, the variant with the "final" update is not done yet.

@haidubogdanhaidubogdanforce-pushed thet_issue_7010_unknown_css_properties branch fromff76342 toec9501dCompareSeptember 28, 2025 10:47
@matthiasblaesingmatthiasblaesing changed the titleAdd missing CSS properties mentioned in #7010Add missing CSS properties : margin-block, pading-block, scroll-behavior, conic-gradient, filter-effectsSep 28, 2025
@matthiasblaesing
Copy link
Contributor

Thank you!

@matthiasblaesingmatthiasblaesing merged commit9cbd154 intoapache:masterSep 28, 2025
59 of 60 checks passed
@haidubogdanhaidubogdan deleted the t_issue_7010_unknown_css_properties branchOctober 9, 2025 15:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@matthiasblaesingmatthiasblaesingmatthiasblaesing left review comments

Assignees

No one assigned

Labels

ci:dev-build[ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page)CSS[ci] enable web job

Projects

None yet

Milestone

NB28

Development

Successfully merging this pull request may close these issues.

Add unknown CSS properties

4 participants

@haidubogdan@matthiasblaesing@mbien@troizet
[8]ページ先頭
©2009-2025 Movatter.jp