Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Php twig: inline comment coloring#8759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@haidubogdan
Copy link
Contributor

@haidubogdanhaidubogdan commentedAug 24, 2025
edited by matthiasblaesing
Loading

This is a pull request to fix Twig 3.15 inline comments. (#8100)

Before :

image

After:

image

It is not a perfect solution as the following snippet will be seen as normal.

{{ "Hello World"|upper # this is an inline comment }}
image

This snippet will trigger a parser error on a real usage.
Unfortunately, the fix for this is more complex and can take more time as it is done on twig top lexer.
I need to check if the "#" symbol is in string or not, if it will finish with a new line or not, for which I sense that jflex lexer has some limitations and the current logic is hard to adapt.

@troizettroizet added the PHP[ci] enable extra PHP tests (php/php.editor) labelAug 24, 2025
@mbienmbien linked an issueAug 25, 2025 that may beclosed by this pull request
Copy link
Member

@tmysiktmysik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me, thank you.

@apacheapache locked and limited conversation to collaboratorsSep 2, 2025
@apacheapache unlocked this conversationSep 2, 2025
@matthiasblaesing
Copy link
Contributor

@haidubogdan could you please update the author information of the commit with your full name? I agree with@tmysik that this is good to go, but the author information should be complete first. Thank you.

@haidubogdanhaidubogdanforce-pushed thet_8100_php_twig_inline_comment_coloring branch fromb1c38e9 tocce14b8CompareSeptember 3, 2025 19:45
@haidubogdan
Copy link
ContributorAuthor

Hi@matthiasblaesing , done, I've updated the Author of the commit.

@matthiasblaesingmatthiasblaesing added this to theNB28 milestoneSep 5, 2025
Copy link
Contributor

@matthiasblaesingmatthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you.

@matthiasblaesingmatthiasblaesing merged commit615dfc8 intoapache:masterSep 5, 2025
31 checks passed
@haidubogdanhaidubogdan deleted the t_8100_php_twig_inline_comment_coloring branchOctober 9, 2025 14:58
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tmysiktmysiktmysik approved these changes

@matthiasblaesingmatthiasblaesingmatthiasblaesing approved these changes

@junichi11junichi11Awaiting requested review from junichi11

Assignees

No one assigned

Labels

PHP[ci] enable extra PHP tests (php/php.editor)

Projects

None yet

Milestone

NB28

Development

Successfully merging this pull request may close these issues.

Twig 3.15 inline comments

4 participants

@haidubogdan@matthiasblaesing@tmysik@troizet

[8]ページ先頭

©2009-2025 Movatter.jp