- Notifications
You must be signed in to change notification settings - Fork914
Php twig: inline comment coloring#8759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Php twig: inline comment coloring#8759
Uh oh!
There was an error while loading.Please reload this page.
Conversation
tmysik left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me, thank you.
matthiasblaesing commentedSep 3, 2025
@haidubogdan could you please update the author information of the commit with your full name? I agree with@tmysik that this is good to go, but the author information should be complete first. Thank you. |
b1c38e9 tocce14b8Comparehaidubogdan commentedSep 3, 2025
Hi@matthiasblaesing , done, I've updated the Author of the commit. |
matthiasblaesing left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you.
615dfc8 intoapache:masterUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
This is a pull request to fix Twig 3.15 inline comments. (#8100)
Before :
After:
It is not a perfect solution as the following snippet will be seen as normal.
This snippet will trigger a parser error on a real usage.
Unfortunately, the fix for this is more complex and can take more time as it is done on twig top lexer.
I need to check if the "#" symbol is in string or not, if it will finish with a new line or not, for which I sense that jflex lexer has some limitations and the current logic is hard to adapt.