- Notifications
You must be signed in to change notification settings - Fork914
Add markdown file template#8701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
makiam commentedAug 1, 2025
Refers to@6020 |
matthiasblaesing left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you.
Please check your author settings for commits, the email looks fine, the realname looks like a nick. It would be great if you could make the suggested change, squash the commit into one and update the author info while doing that.
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| @TemplateRegistration(folder="Other",content="resources/Template.md",displayName="Markdown File",description="resources/Template.html",position=500) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please addrequireProject = false, Markdown files will work fine outside projects.
matthiasblaesing commentedAug 2, 2025
@makiam thanks for the update. Could you please recheck the author (see "From:" line here:https://github.com/apache/netbeans/pull/8701.patch). See for example:https://betterstack.com/community/questions/how-to-change-commit-author-for-single-commit/ |
matthiasblaesing commentedAug 6, 2025
@makiam I missed that on the first pass: the template file has no license header (and in this case can't carry one). For that case there needs to be an information added to Seehttps://github.com/apache/netbeans/blob/master/nbbuild/antsrc/org/netbeans/nbbuild/extlibs/licenseinfo/CommentType.java#L22. That is evaluated by the |
Signed-off-by: Maksim Khramov <maxtemplaar@gmail.com>
b1c8fc7 intoapache:masterUh oh!
There was an error while loading.Please reload this page.
matthiasblaesing commentedAug 7, 2025
@makiam thank you - merged into master and so this will become part of NB28. |
Uh oh!
There was an error while loading.Please reload this page.
Markdown template file with formatting tags showcase