this would have to make sure that the currently checked out branch isn't offered for deletion, since this can't be done.

the repo browser does have the delete action too and does it correctly:

Thx, everything seems to work correctly beacuse if smth is wrong here, there witll be a GitException which shows the error:

So I'm fine with this behaviour.

right, saw that. This isn't great. Tools should not offer actions for operations which aren't supported by the impl.

So you mean just disable the ok butten when the current checked out branch is selected?

So you mean just disable the ok butten when the current checked out branch is selected?

something like that yeah, although removing the current branch from the list might be easier since it wouldn't involve having to update the branch selector UI which is probably used in many places.

not tested:

action:

RepositoryInfoinfo =RepositoryInfo.getInstance(repository);HashMap<String,GitBranch>branches =newHashMap<>(info.getBranches());branches.remove(info.getActiveBranch().getName());if (branches.isEmpty()) {// TODO notify: "can't delete active branch"return;        }BranchSelectorselector =newBranchSelector(repository,branches);

new BranchSelector constructor:

publicBranchSelector(Filerepository,HashMap<String,GitBranch>branches) {this.revisionPicker =newRevisionDialogController(repository,newFile[0],branches,null);panel =newSelectBranchPanel(revisionPicker.getPanel());    }

would be nice to overwrite the enable() method of the action and turn it off if there is just one branch, but I am not 100% if it is a good idea to run the branch query on the EDT, I haven't looked into this deeper.

enable method:

    @Override    protected boolean enable(Node[] activatedNodes) {        Map.Entry<File, File[]> actionRoots = getActionRoots(getCurrentContext(activatedNodes));        if (actionRoots != null) {            RepositoryInfo info = RepositoryInfo.getInstance(actionRoots.getKey());            return info.getBranches().size() > 1 && super.enable(activatedNodes);        }        return false;    }

with that method you don't need the TODO

@mbien added your requested code, I tested it with quick search -> delete branch, Menu -> team -> git -> branch ->delete branch and with the popup action on the project node. Seem working now. Thx.

If there are no other concerns, I will probably merge this next week.