Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Create a single LauncherSession for invocations of JUnitPlatformProvider#863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@marcphilipp
Copy link
Contributor

Prior to this commit,JUnitPlatformProvider created multipleLauncherSessions for some executions, for example whenforkTestSet wasnull or when rerunning failed tests. This caused registeredLauncherSessionListeners registered viaServiceLoader on the JUnit Platform to be called multiple times. As they are intended to set up and tear down resources, this had the potential of unnecessarily slowing down test execution.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Runmvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
theApache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Prior to this commit, `JUnitPlatformProvider` created multiple`LauncherSessions` for some executions, for example when `forkTestSet`was `null` or when rerunning failed tests. This caused registered`LauncherSessionListeners` registered via `ServiceLoader` on the JUnitPlatform to be called multiple times. As they are intended to set up andtear down resources, this had the potential of unnecessarily slowingdown test execution.
@Bukama
Copy link
Contributor

Hey@marcphilipp Thanks for the PR! Would you call this a bugfix (as not intended to use this way) or enhancement?

@marcphilipp
Copy link
ContributorAuthor

I think it's not strictly a bug so I would call it an enhancement. 🙂

Bukama and olamy reacted with thumbs up emoji

@olamy
Copy link
Member

Looks like an excellent change. Thanks for this.

@olamyolamy merged commitbfa3cca intoapache:masterJul 4, 2025
26 checks passed
@github-actions
Copy link

@olamy The PR can't be associated to a milestone, because there are multiple open milestones. Please add the text "branch: master" to the description to the milestone where this PR belongs to.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

@marcphilippmarcphilipp

Labels

enhancementNew feature or request

Projects

None yet

Milestone

3.5.4

Development

Successfully merging this pull request may close these issues.

3 participants

@marcphilipp@Bukama@olamy

[8]ページ先頭

©2009-2025 Movatter.jp