Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix dotnet test Command Not Recognizing NUnit3TestAdapter#164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@mobilebilly
Copy link
Contributor

Fix for Issue#109

This fix addresses the issue where the dotnet test command cannot recognize the NUnit3TestAdapter in existing ItemGroup elements.

Changes Made:

Moved the reference to NUnit3TestAdapter to an ItemGroup without a TargetFramework condition.

Move reference to NUnit3TestAdapter to ItemGroup without TargetFramework condition
@FreeAndNilFreeAndNil changed the base branch frommaster toFeature/111-Dropping-support-for-older-runtimesAugust 3, 2024 18:19
@FreeAndNil
Copy link
Contributor

@mobilebilly Thank you very much for your contribution.
I retargeted you pull request to Feature/111... because this is our current development branch for 3.0.0.
Can you please fix the conflicts and test the changes?

@FreeAndNilFreeAndNil self-requested a reviewAugust 3, 2024 18:21
@FreeAndNilFreeAndNil added this to the3.0.0 milestoneAug 3, 2024
@mobilebilly
Copy link
ContributorAuthor

@FreeAndNil , no problem.
The conflicts have been fixed, and my branch is now up-to-date with the latest changes from the upstream branch Feature/111....
Please review the updated pull request and let me know if there are any further changes needed.

Copy link
Contributor

@FreeAndNilFreeAndNil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please adjust as proposed, then we can merge.

Set IsTestProject to true and clean up garbage from old project file.
@mobilebilly
Copy link
ContributorAuthor

@FreeAndNil, the additional change in the test project is done. thank you

Copy link
Contributor

@FreeAndNilFreeAndNil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks a lot.

@FreeAndNilFreeAndNil merged commit60d4fbc intoapache:Feature/111-Dropping-support-for-older-runtimesAug 5, 2024
FreeAndNil added a commit that referenced this pull requestAug 6, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@FreeAndNilFreeAndNilFreeAndNil approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mobilebilly@FreeAndNil

[8]ページ先頭

©2009-2025 Movatter.jp