Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Restrict LDAP access via JNDI#608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
rgoers merged 4 commits intorelease-2.xfromldap-controls
Dec 5, 2021
Merged

Restrict LDAP access via JNDI#608

rgoers merged 4 commits intorelease-2.xfromldap-controls
Dec 5, 2021

Conversation

rgoers
Copy link
Member

Restricts access to LDAP via JNDI.

shinytang6, Fnck, StyleTang, jack-yu-matrix, bertondeng, chrishna1, alejandro-du, dzikoysk, tt4g, davidxia, and 179 more reacted with thumbs up emoji26, sanjaykrishnanem, janaekj, heypoom, the-zucc, gregsadetsky, BeyondMagic, TomA-R, abiriadev, JellyBrick, and 19 more reacted with hooray emojidzikoysk, myuwono, dannyhpy, asdhuman-dev, Drullkus, stbischof, sureshg, botic, aemxn, Freeze777, and 61 more reacted with heart emojimsdevanms, j9t, kmiklas, SchlegelS0208, abiriadev, ashishxpatel, taiki-okano, fkztw, Big-al, avish0694, and 9 more reacted with rocket emojiTropix126, ice1000, debu99, voznesenskym, DoubleF3lix, spotlightishere, SanderDemeester, Kara-4search, imkunet, joshwenke, and 320 more reacted with eyes emoji
publicstaticList<String>getLocalIps() {
List<String>localIps =newArrayList<>();
localIps.add("localhost");
localIps.add("127.0.0.1");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Perhaps IPv6 as well[::1]? (brackets may or may not be necessary depending how we extract the host)

beorn247, svenhaag, rdev66, iam-py-test, dannyhpy, mojiezhong, henry701, nayeemd, kevin-valerio, auliarshad, and 3 more reacted with heart emojikevin-valerio, sbimochan, dingjianghangs, ruonanxiao9527, GoJoeyGo, and Nato4ka3003 reacted with eyes emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I could have but this pre-seeding really isn't necessary as they show up in the while loop anyway.

MichelleJacksonConsulting reacted with laugh emoji
Copy link
Member

@vyvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great job@rgoers! Thanks so much for such a prompt action!

I guess you're gonna incorporate the suggestedallowed schemes configuration knob too.

I am also inclined to add a property (log4j2.jndiLookupEnabled?) for toggling JNDI lookups and disable it by default. What do you think?

garydgregory, amerine, extremeheat, PersonBelowRocks, calvernaz, iam-py-test, andreaswimmer, nihonmatsu, mdirkse, dwhitz, and 9 more reacted with thumbs up emoji
permanentAllowedClasses.add(Float.class.getName());
permanentAllowedClasses.add(Integer.class.getName());
permanentAllowedClasses.add(Long.class.getName());
permanentAllowedClasses.add(Number.class.getName());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The rest of the classes arefinal, thoughNumber isn't. I would keepNumber out of this list.

Hc747 reacted with heart emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This comment is on the first commit. The second commit added filtering by protocol.
I haven't added a complete kill switch and wasn't planning to. Rather than doing that I think it would be better to figure out a generic way to "hide" plugins.
More importantly, the class is abstract so can never appear here. I am not inspecting sub-classes, only the actual class being instantiated. I will remove Number.

Comment on lines 57 to 58
privatestaticfinalList<String>permanentAllowedHosts =newArrayList<>();
privatestaticfinalList<String>permanentAllowedClasses =newArrayList<>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Mind upper-casing these twostatics, please?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I could go either way on casing here since the included values aren't constant (e.g. NetUtils.getLocalIps() is dynamic).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I agree with@carterkozak that lower-case feels more appropriate since these are not immutable lists.

sudeepparameswaran, manseok-kim, lukasz-chorazy-mox, and linco95 reacted with thumbs up emoji
importstaticorg.junit.jupiter.api.Assertions.fail;

/**
* Test LDAP object
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
*TestLDAPobject
*MaliciousLDAPobjectthatshouldn't be deserialized.
*
*@seeJndiLdapLookupTest

aidanhasaknife, lambda-fairy, attilaszia, janbritz, sbimochan, bhattaraib58, and UditE5 reacted with thumbs up emoji
import static org.junit.Assert.fail;

/**
* JndiLookupTest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
*JndiLookupTest
*LDAP-specializedtestsfor {@linkJndiLookup}.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Rats. You just reminded me I need to rename this test as it is no longer specific to LDAP.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

yes need to write a more generic test

/**
* JndiLookupTest
*/
public class JndiLdapLookupTest {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@rgoers, I cannot see the test where the exploit indeed works when the prevention mechanism is not in place. Am I missing something?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I tested that before I wrote any code. Once the code was added it isn't possible for it to happen any more as we no longer support Referenceable objects and there is no way to re-enable them. They are simply too dangerous.

LOGGER.warn("Attempt to access ldap server not in allowed list");
returnnull;
}
Attributesattributes =this.context.getAttributes(name);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Are we confident the attributes resolved here are equivalent to the results ofcontext.lookup? I imagine the attributes could change over time.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I assume you mean the attributes associated with the returned item. All the attributes returned from LDAP for Java objects are specified inhttps://datatracker.ietf.org/doc/html/rfc2713.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I want to make sure thatcontext.getAttributes(name) verifies against the same data (cached without any sort of refresh or network call) as the subsequent call tocontext.lookup(name), otherwise the verification isn't very helpful.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Perfect, thank you for the explanation, I'm not very familiar with these components :-)

…servers and classes that can be accessed via LDAP.
@rgoersrgoers merged commitc77b3cb intorelease-2.xDec 5, 2021
@wcc526
Copy link

wcc526 commentedDec 9, 2021
edited
Loading

Is it a security vulnerability?

ErwannRobin, yuriy-pylypenko-exa, and OlivierLaflamme reacted with thumbs up emojifactoidforrest reacted with thumbs down emojisyuilo, fsampaio, rdev66, xMdb, MartinThoma, e-dard, justinpombrio, Xon, and paolomainardi reacted with heart emojizhangyoufu, sec-run, yanghanlin, GalvinGao, lazmond3, ice1000, debu99, sickcodes, gatoborrachon, sureshg, and 38 more reacted with rocket emojiskimmilk, nfmelendez, jcsumlin, OhPointFive, xMdb, fproulx-boostsecurity, ebanDev, jedieaston, e-dard, diadatp, and 12 more reacted with eyes emoji

@Glavo
Copy link

Is it a security vulnerability?

I think it is.

It is very surprising that this critical security issue does not seem to have received due attention. It was reported to Apache half a month ago, but it was not fixed until five days ago. Even today, it has not released a new stable version to solve it.

anqur, shaggyfrog, tcmot, CharlyZest, Snoozepilled, profi248, xrzhev, LucJosin, glasslion, CherryRum, and 22 more reacted with thumbs up emojidakl, ebourg, JanecekPetr, FloridSleeves, justsh, xMdb, ankitshaw, DjDeveloperr, manjula-aw, havstein, and nickhshu reacted with thumbs down emojiice1000, CharlyZest, semjon00, k-makarov, dario-boberek, Safari77, ebanDev, xMdb, zevisert, bczhc, and 3 more reacted with laugh emojiyidongnan, hawkfalcon, SASUKE40, PersonBelowRocks, profi248, tsukumijima, matil019, semjon00, LucJosin, proshin-roman, and 7 more reacted with confused emojiseiyab, webmaster777, rdev66, xMdb, nickmartin1ee7, dwhitz, mohnkhan, gabyfulchic, ericpapaluca, joshbuker, and 2 more reacted with eyes emoji

@garydgregory
Copy link
Member

Is it a security vulnerability?

I think it is.

It is very surprising that this critical security issue does not seem to have received due attention. It was reported to Apache half a month ago, but it was not fixed until five days ago. Even today, it has not released a new stable version to solve it.

Oh so glad you show such appreciation for the work of volunteers...

arizvisa, ebourg, JanecekPetr, AvasDream, mikkorantalainen, jensim, deztructor, szaszm, Ciruman, justsh, and 23 more reacted with thumbs up emojianqur, nightpool, WesJD, ChickenKaraage, glasslion, shaggyfrog, z-glitch, cuteBoiButt, xiaoc024, hcwesson, and 66 more reacted with thumbs down emojizhangyoufu, yidongnan, Glavo, cuteBoiButt, dlo, allejo, ice1000, spotlightishere, anqur, glasslion, and 12 more reacted with confused emoji

@Glavo
Copy link

Glavo commentedDec 9, 2021
edited
Loading

Is it a security vulnerability?

I think it is.
It is very surprising that this critical security issue does not seem to have received due attention. It was reported to Apache half a month ago, but it was not fixed until five days ago. Even today, it has not released a new stable version to solve it.

Oh so glad you show such appreciation for the work of volunteers...

@garydgregory

I wonder when log4j 2.15 will be officially released? It's hard to imagine that the craziest vulnerability this year has not been solved in the release half a month after it was reported.

Its impact is unimaginable. Countless services using log4j2 are exposed to the risk of being attacked, and the way to attack them is surprisingly simple. Even now I dare not open my minecraft server, because any member can attack it if they want - he/she can easily control my server by sending a text through the chat bar.

Is there anyone dealing with this matter urgently? It's really incomprehensible that I didn't see Apache give any emergency warning under such a serious problem.

khaledavarteq, SmilingCatEntertainment, ClintRajaniemi, and yuriy-pylypenko-exa reacted with thumbs up emojiFirminator, dwhitz, John200410, GSPP, the-zucc, and joshbuker reacted with rocket emoji

@GalvinGao
Copy link

GalvinGao commentedDec 9, 2021
edited
Loading

Is it a security vulnerability?

I think it is.
It is very surprising that this critical security issue does not seem to have received due attention. It was reported to Apache half a month ago, but it was not fixed until five days ago. Even today, it has not released a new stable version to solve it.

Oh so glad you show such appreciation for the work of volunteers...

@garydgregory

I wonder when log4j 2.15 will be officially released? It's hard to imagine that the craziest vulnerability this year has not been solved in the release half a month after it was reported.

Its impact is unimaginable. Countless services using log4j2 are exposed to the risk of being attacked, and the way to attack them is surprisingly simple. Even now I dare not open my minecraft server, because any member can attack it if they want - he/she can easily control my server by sending a text through the chat bar.

Is there anyone dealing with this matter urgently? It's really incomprehensible that I didn't see Apache give any emergency warning under such a serious problem.

+1, and we are in desperate need of a CVE and security advisory to be announced asap. This could affect hundreds of thousands, if not millions, of services actively running on the internet.

We of course appreciate the efforts from contributors, but overall this is a major security issue that needs a new version release and a security advisory.

Glavo, adrian154, zhangyoufu, cuteBoiButt, MrPowerGamerBR, Bvngee, fabianhjr, ice1000, spotlightishere, SASUKE40, and 59 more reacted with thumbs up emoji

@garydgregory
Copy link
Member

Your patience will soon be rewarded...

@garydgregory
Copy link
Member

Also, if this matters to you so much, why not show it with a donation to the Apache Software Foundationhttps://www.apache.org/foundation/contributing.html or this project's main contributorhttps://github.com/sponsors/rgoers ?

fabianhjr, remkop, sanWenyua, niij, boustrophedon, sureshg, matthewlowry, KengoTODA, arizvisa, rmsy, and 85 more reacted with thumbs up emojiimkiva, kg, anqur, nightpool, Elias-Poor, ChickenKaraage, glasslion, shaggyfrog, reitowo, choleraehyq, and 77 more reacted with thumbs down emojiice1000, anqur, sbvkrishna, jensim, k-makarov, rfrht, dannyhpy, ebanDev, horacio, haomingz, and 4 more reacted with laugh emojierijohnt, sebastiankirsch, jensim, rfrht, Ciruman, jimen0, kiwiz, guusdk, rzo1, fproulx-boostsecurity, and 18 more reacted with heart emojigoldstar611, fproulx-boostsecurity, horacio, DjDeveloperr, sidaffordit, BeyondMagic, waruqi, and Glitchfix reacted with rocket emojijoshbuker, Glitchfix, and smallx reacted with eyes emoji

@ThiemoBovenThiemoBoven mentioned this pull requestDec 9, 2021
3 tasks
@remkop
Copy link
Contributor

Is it a security vulnerability?

I think it is.
It is very surprising that this critical security issue does not seem to have received due attention. It was reported to Apache half a month ago, but it was not fixed until five days ago. Even today, it has not released a new stable version to solve it.

Oh so glad you show such appreciation for the work of volunteers...

@garydgregory
I wonder when log4j 2.15 will be officially released? It's hard to imagine that the craziest vulnerability this year has not been solved in the release half a month after it was reported.
Its impact is unimaginable. Countless services using log4j2 are exposed to the risk of being attacked, and the way to attack them is surprisingly simple. Even now I dare not open my minecraft server, because any member can attack it if they want - he/she can easily control my server by sending a text through the chat bar.
Is there anyone dealing with this matter urgently? It's really incomprehensible that I didn't see Apache give any emergency warning under such a serious problem.

+1, and we are in desperate need of a CVE and security advisory to be announced asap. This could affect hundreds of thousands, if not millions, of services actively running on the internet.

We of course appreciate the efforts from contributors, but overall this is a major security issue that needs a new version release and a security advisory.

My understanding is that the procedure is to hold off on announcing the vulnerability until a patch is available. (Seehttps://www.apache.org/security/).

For background:

The team is taking it seriously. As Gary said, we are all volunteers working on this in our spare time. We are also in different time zones so communication is not instantaneous. If you think things can be improved, that's great! We need more people like you and I would encourage you toget involved!

We are in the process of getting a release out with the fix. During review, some security experts found a new vulnerability in our fix (a way to bypass the fix). This has been addressed and we are now in the process of reviewing the updated 2nd release candidate.

Usually (as per ASF rules) the teamshould wait 72 hours after creating a release candidate before publishing the release to give the community enough time to review and cast their votes. We are building consensus to shorten that window for this particular release, given its urgency.

mihaitodor, fabianhjr, kg, sanWenyua, z-glitch, dengzhhu653, rmsy, loudar, yjqg6666, CharlyZest, and 70 more reacted with thumbs up emojiqixils, P7XXTMX, sgammon, Santiago-j-s, HexedHero, fabianhjr, hawkfalcon, cyp0633, GalvinGao, sanWenyua, and 52 more reacted with heart emojisgammon, EdixonAlberto, ruppde, nihonmatsu, DjDeveloperr, the-zucc, stanleyjzheng, 2br-2b, greek1979, and smallx reacted with eyes emoji

@zhangyoufu
Copy link

zhangyoufu commentedDec 9, 2021
edited
Loading

You can't ask everybody to upgrade to 2.15 at once. And theformatMsgNoLookups option is available to log4j ≥ 2.10 only.

Thanks toLOG4J2-703, I think it's quite safe to removeorg/apache/logging/log4j/core/lookup/JndiLookup.class fromlog4j-core-*.jar as a workaround. Justzip -q -d log4j-core-*.jar org/apache/logging/log4j/core/lookup/JndiLookup.class to disable${jndi:...} functionality completely.

I posted all log4j-core jar withJndiLookup.class removed athttps://github.com/zhangyoufu/log4j2-without-jndi for reference. Simple local test looks promising.

zhugw, brunoborges, Freeze777, centminmod, lazaroblanc, teemualander, zTrix, wlanboy, bkreider, tyronecai, and 7 more reacted with thumbs up emojichrismyers81, Novynn, brunoborges, Freeze777, yammyshep, zTrix, and 0x0334 reacted with hooray emojipandada8, Victor-martinelli, boholder, vy, pcohensc, Fnck, sascha-broich, mikkorantalainen, jkasarherou, Santiago-j-s, and 13 more reacted with heart emojiahxxm, Nyangawa, imweijh, ice1000, hitsumabushi, Kevin-sa, cbmixx, got4416, kristi71111, virusdefender, and 20 more reacted with rocket emojirobotrapta, pcohensc, Santiago-j-s, brunoborges, Freeze777, henry701, bradvido, zTrix, imyxiao, and smallx reacted with eyes emoji

@remkop
Copy link
Contributor

remkop commentedDec 10, 2021
edited
Loading

Update: the vote for log4j-2.15.0 passed and the release is in progress.

I can see the log4j web site reflecting thelog4j 2.15.0 release, but I cannot see the 2.15.0artifacts on Maven Central yet at this moment. It may take a few hours before mirror servers are synchronized and the artifacts become available for you.

An announcement email for the release will be sent out soon (within 24 hours - we usually wait some time for the mirror servers to catch up).

Thank you@zhangyoufu for the suggested workaround for older versions of log4j to remove theJndiLookup.class class! The team likes your idea and we will include the workaround you suggested in the release notes and announcement email. Many thanks!

garydgregory, Glavo, ROMVoid95, adamkotwasinski, Tropix126, HexedHero, suraciii, soren121, BenBeng, thenickdude, and 39 more reacted with thumbs up emojimoonming, Glavo, soren121, Santiago-j-s, gnomeria, espenhk, phorsuedzie, BeyondMagic, stanleyjzheng, greek1979, and 3 more reacted with heart emoji

@moonming
Copy link
Member

@remkop thanks for your great work 👍
I come from theApache APISIX community, and we can intercept this security vulnerability at the API gateway level to provide some help. I wonder if there are such regular expression rules? thanks

remkop, this, henry701, and aleksf-awx reacted with heart emoji

@yuezk
Copy link

Hi@rgoers, is log4j 1.x vulnerable?

@remkop
Copy link
Contributor

remkop commentedDec 10, 2021
edited
Loading

Hi@rgoers, is log4j 1.x vulnerable?

Hi@yuezk, as far as I can tell, log4j 1.x does not support lookups.I also could not find any other reference to JNDI in thelog4j 1.x source code. So, no guarantees but it looks like 1.x is not impacted by this vulnerability.CORRECTION:log4j 1.x contains a JMS Appender which can use JNDI. So I would say that, yes, log4j 1.x is also impacted by this vulnerability (Thank you@garydgregory for pointing this out).

Update (2021-12-11 09:09 JST): according tothis analysis by@ceki (the author of log4j 1.x), Log4j 1.x is not impacted, since it does not have lookups, and the JMS Appender only loads Strings from the remote server, not serialized objects.

Update (2021-12-12 10:09 JST): according tothis analysis by@TopStreamsNet, strictly speaking, applications using Log4j 1.x may be impacted if their configuration uses JNDI. However, the risk is much lower.

Note that log4j 1.x isEnd of Life and hasother security vulnerabilities that will not be fixed.So we do not recommend using log4j 1.x as a way to avoid this security vulnerability. The recommendation is to upgrade to 2.15.0.

this, vasilegroza, centminmod, damalhot, henry701, yihezkel, s207307, cpoenisch, Gesias, ThomasG77, and 40 more reacted with thumbs up emojimikkorantalainen, freedomskyx, taladrane, MysterAitch, s207307, Gesias, thesp0nge, tacahiroy, msgmsn, Dieterbe, and 7 more reacted with heart emojis207307, vnsavage, Dieterbe, quinoescobar, and antemasqued reacted with rocket emojiFazx, CharlyZest, cloudZQY, benmyb, Qi382, qw2536807, alanorth, dentarg, yssunshine, izhangzhihao, and 32 more reacted with eyes emoji

@garydgregory
Copy link
Member

garydgregory commentedDec 10, 2021 via email

We need to look at the log4j 1 JMS Appender which I thought had at leastprogrammatic support for JNDI.Gary
On Thu, Dec 9, 2021, 20:26 Remko Popma ***@***.***> wrote: Hi@rgoers <https://github.com/rgoers>, is log4j 1.x vulnerable? Hi@yuezk <https://github.com/yuezk>, as far as I can tell, log4j 1.x does not support lookups. I also could not find any other reference to JNDI in the log4j 1.x source code <http://svn.apache.org/viewvc/logging/log4j/trunk/>. So, no guarantees but it looks like 1.x is not impacted by this vulnerability. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#608 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJB6NYD7R35WOHFKBO3ILLUQFJLHANCNFSM5JA3ZEGA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
remkop, chrismyers81, greek1979, and ClintRajaniemi reacted with thumbs up emojiremkop reacted with heart emoji

@garydgregory
Copy link
Member

garydgregory commentedDec 10, 2021 via email

On Thu, Dec 9, 2021, 20:30 Gary Gregory ***@***.***> wrote: We need to look at the log4j 1 JMS Appender which I thought had at least programmatic support for JNDI. Gary On Thu, Dec 9, 2021, 20:26 Remko Popma ***@***.***> wrote:> Hi@rgoers <https://github.com/rgoers>, is log4j 1.x vulnerable?>> Hi@yuezk <https://github.com/yuezk>, as far as I can tell, log4j 1.x> does not support lookups. I also could not find any other reference to JNDI> in the log4j 1.x source code> <http://svn.apache.org/viewvc/logging/log4j/trunk/>. So, no guarantees> but it looks like 1.x is not impacted by this vulnerability.>> —> You are receiving this because you were mentioned.> Reply to this email directly, view it on GitHub> <#608 (comment)>,> or unsubscribe> <https://github.com/notifications/unsubscribe-auth/AAJB6NYD7R35WOHFKBO3ILLUQFJLHANCNFSM5JA3ZEGA>> .> Triage notifications on the go with GitHub Mobile for iOS> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>> or Android> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.>>
remkop, matil019, and ClintRajaniemi reacted with thumbs up emojiremkop and fahlke reacted with heart emoji

jsoo1 pushed a commit to awakesecurity/nixpkgs that referenced this pull requestJul 17, 2022
jsoo1 pushed a commit to awakesecurity/nixpkgs that referenced this pull requestJul 18, 2022
Copy link

@alphawoodexecalphawoodexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

log4j-core/pom.xml

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ryanotellaryanotellaryanotella left review comments

@remkopremkopremkop left review comments

@axdimitaraxdimitaraxdimitar left review comments

@UditE5UditE5UditE5 left review comments

@alphawoodexecalphawoodexecalphawoodexec left review comments

@vyvyvy requested changes

@carterkozakcarterkozakcarterkozak approved these changes

@jeromin10jeromin10jeromin10 approved these changes

@taogeaiddtaogeaiddtaogeaidd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

69 participants
@rgoers@wcc526@Glavo@garydgregory@GalvinGao@remkop@zhangyoufu@moonming@yuezk@JLLeitschuh@linux-ops@Baoqi@sunnypav@suesunss@utam0k@mageshwarang@iamamoose@sysmat@Rongmario@peturthors@diegomrsantos@TiloGit@albertinix@jvz@vy@mosajjal@lawndoc@philipwhiuk@ahahu@ceki@Marcono1234@Firminator@TopStreamsNet@qqchaozai@GSPP@carterkozak@moparthisai@tony--@ancms2600@sourabhsparkala@chming1016@svdHero@kmindi@asokolov-flex@rgmz@uszeiss@sushain-pandit@WesternGun@felixbarny@drorbrillsnps@Kirill89@bynt@sellexx-stephan@brunoborges@quericy@vlsi@SpComb@mallman@jschauma@yjqg6666@4ra1n@mrdgsmith@quaff@ryanotella@axdimitar@jeromin10@UditE5@taogeaidd@alphawoodexec

[8]ページ先頭

©2009-2025 Movatter.jp