- Notifications
You must be signed in to change notification settings - Fork655
fix(plugins): add missing scope-config and missing projects in grafana for argocd#8642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
rbstp wants to merge1 commit intoapache:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+223 −12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…a for argocdThe scope-config was missing in the initial implementation, which prevent the DORA metrics to be collected.In Grafana, you could not select the projects, so only ALL was available as an option. I also moved the graphs under the correct sections.For the comment in the issueapache#5207 (comment)
ayushkmr approved these changesNov 20, 2025
ayushkmr left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Minor Notes:
- Helper function firstNonEmpty() could be reusable across plugins
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
component/config-uiThis issue or PR relates to config-ui component/extThis issue or PR relates to external components, such as Grafana pr-type/bug-fixThis PR fixes a bug size:LThis PR changes 100-499 lines, ignoring generated files.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The scope-config was missing in the initial implementation, which prevent the DORA metrics to be collected.
In Grafana, you could not select the projects, so only ALL was available as an option. I also moved the graphs under the correct sections.
Does this close any open issues?
For the comment in the issue#5207 (comment)
Screenshots
scope-config
Grafana
Other Information
Used the config from#8639 for dev-containers and it worked without issue.