Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(jenkins): add branch filtering for Jenkins jobs#8601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
GoSimplicity wants to merge26 commits intoapache:main
base:main
Choose a base branch
Loading
fromGoSimplicity:main

Conversation

@GoSimplicity
Copy link
Contributor

add branch filtering for Jenkins jobs#8579

GoSimplicityand others added24 commitsAugust 21, 2025 16:11
@dosubotdosubotbot added size:LThis PR changes 100-499 lines, ignoring generated files. component/config-uiThis issue or PR relates to config-ui component/pluginsThis issue or PR relates to plugins pr-type/feature-developmentThis PR is to develop a new feature labelsOct 2, 2025
Copy link
Contributor

@kleshklesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

After reading issue#8579, could the problem be thatscope_api.go andremote_api.go are returning incorrect scopes?

@GoSimplicity
Copy link
ContributorAuthor

After reading issue#8579, could the problem be thatscope_api.go andremote_api.go are returning incorrect scopes?

Thanks for the review I checked bothremote_api.go andscope_api.go. You're right to question this.
From what I can see:

  • remote_api.go looks fine - MultiBranchProject is treated as a scope (it's inscopesWithJobs), so its branch jobs won't show up as selectable scopes in the UI
  • The issue in[Feature][Jenkins Connection] Introduce filtering of branch builds #8579 is different - when you select a MultiBranchProject, the collector grabs all branch jobs underneath it, converts them tocicd_pipelines, and they all show up in Grafana
    My PR filters branches during collection so only matching ones get into Grafana. But you're right that we should check ifGetScopeList is also returning these auto-collected branch jobs alongside user-selected scopes.
    Should I add logic to distinguish user-selected scopes from auto-collected branch jobs? Or is filtering at collection time enough for this use case?

@petkostaspetkostas changed the titlefeat: add branch filtering for Jenkins jobsfeat(jenkins): add branch filtering for Jenkins jobsOct 9, 2025
@klesh
Copy link
Contributor

Thanks for the explanation.
@OG256 could you provide some context/input on this?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@kleshkleshklesh left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

component/config-uiThis issue or PR relates to config-uicomponent/pluginsThis issue or PR relates to pluginspr-type/feature-developmentThis PR is to develop a new featuresize:LThis PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GoSimplicity@klesh

[8]ページ先頭

©2009-2025 Movatter.jp