- Notifications
You must be signed in to change notification settings - Fork9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
YARN-11793: Replace Grizzly with Jetty in Jersey Test Framework#7497
Open
susheelgupta7 wants to merge4 commits intoapache:trunkChoose a base branch
base:trunk
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+22 −15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
hadoop-yetus commentedMar 12, 2025
💔-1 overall
This message was automatically generated. |
@cnauroth Could you please review this patch. |
@susheelgupta7 I think this upgrade is reasonable for me, but it may need to wait until the Yarn JUnit5 upgrade is completed and merged. My expected timeline is about one week. |
hadoop-yetus commentedMar 18, 2025
💔-1 overall
This message was automatically generated. |
…y/webapp/WebAppContext
hadoop-yetus commentedMar 20, 2025
💔-1 overall
This message was automatically generated. |
hadoop-yetus commentedMar 20, 2025
💔-1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@susheelgupta7 , thank you for the new patch. I agree with@slfan1989 on sequencing this after the YARN JUnit 5 upgrades. Then, we can check for a clean test run here.
@cnauroth Thank you for your message! Starting today, I will continue with the YARN JUnit 5 upgrade. I was a bit tied up with work over the past few days, which caused a slight delay. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA:YARN-11793: Replace Grizzly with Jetty in Jersey Test Framework
Replaced jersey-test-framework-provider-grizzly2 with jersey-test-framework-provider-jetty to better align with Hadoop's production and provide more real HTTP testing environment.
jersey-test-framework-provider-inmemory was avoided as it doesn't properly simulate real HTTP behavior and it is not consistent with the production setup. Since RMWebServices depends on actual HTTP interactions, using Jetty makes the testing framework more reliable and closer to real-world scenarios.
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?