Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

HDFS-17749. [ARR] Fix wrong results due to the wrong usage of asyncComplete in getListing.#7466

Merged
KeeProMise merged 4 commits intoapache:trunkfromhfutatzhanghb:HDFS-17749
Mar 25, 2025

Conversation

hfutatzhanghb
Copy link
Contributor

@hfutatzhanghbhfutatzhanghb commentedMar 5, 2025•
edited
Loading

Description of PR

May get wrong results due to the wrong usage of asyncComplete in getListing RPC.

The root cause is as below:

asyncComplete(null);// Handler threadasyncApply(() -> {getFileInfo();// issue a rpc request.asyncApply();// AsyncRepsonder thread.});asyncApply(() -> {//do something.});// Handler thread, current thread's CompletableFuture object is in complete status.

How was this patch tested?

Add unit tests TestRouterAsyncMountTable.java.

How to reproduce?

Use original codes to run TestRouterAsyncMountTable.java
Some of unit tests will not pass due to the inaccurate results.

@hadoop-yetus
Copy link

💔-1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 19sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 1scodespell was not available.
+0 🆗detsecrets0m 1sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any@author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚mvninstall23m 43strunk passed
+1 💚compile0m 36strunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚compile0m 28strunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚checkstyle0m 23strunk passed
+1 💚mvnsite0m 29strunk passed
+1 💚javadoc0m 30strunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javadoc0m 20strunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚spotbugs0m 56strunk passed
+1 💚shadedclient20m 41sbranch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚mvninstall0m 18sthe patch passed
+1 💚compile0m 29sthe patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javac0m 29sthe patch passed
+1 💚compile0m 19sthe patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚javac0m 19sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 14sthe patch passed
+1 💚mvnsite0m 21sthe patch passed
+1 💚javadoc0m 18sthe patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javadoc0m 16sthe patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚spotbugs0m 58sthe patch passed
+1 💚shadedclient24m 7spatch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌unit41m 54s/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txthadoop-hdfs-rbf in the patch passed.
+1 💚asflicense0m 24sThe patch does not generate ASF License warnings.
119m 9s
ReasonTests
Failed junit testshadoop.hdfs.server.federation.router.TestRouterHttpServerXFrame
SubsystemReport/Notes
DockerClientAPI=1.48 ServerAPI=1.48 base:https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7466/2/artifact/out/Dockerfile
GITHUB PR#7466
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
unameLinux 2ca3f4b4c3b6 5.15.0-130-generic#140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/bin/hadoop.sh
git revisiontrunk /da5fef7
Default JavaPrivate Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Test Resultshttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7466/2/testReport/
Max. process+thread count2859 (vs. ulimit of 5500)
modulesC: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
Console outputhttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7466/2/console
versionsgit=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.14.0https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔-1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 48sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 1scodespell was not available.
+0 🆗detsecrets0m 1sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any@author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚mvninstall40m 49strunk passed
+1 💚compile1m 11strunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚compile0m 41strunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚checkstyle0m 32strunk passed
+1 💚mvnsite0m 45strunk passed
+1 💚javadoc0m 42strunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javadoc0m 32strunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚spotbugs1m 35strunk passed
+1 💚shadedclient39m 2sbranch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚mvninstall0m 35sthe patch passed
+1 💚compile1m 4sthe patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javac1m 4sthe patch passed
+1 💚compile0m 34sthe patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚javac0m 34sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 20sthe patch passed
+1 💚mvnsite0m 37sthe patch passed
+1 💚javadoc0m 31sthe patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javadoc0m 25sthe patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚spotbugs1m 31sthe patch passed
+1 💚shadedclient39m 25spatch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚unit50m 6shadoop-hdfs-rbf in the patch passed.
+1 💚asflicense0m 35sThe patch does not generate ASF License warnings.
183m 54s
SubsystemReport/Notes
DockerClientAPI=1.48 ServerAPI=1.48 base:https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7466/1/artifact/out/Dockerfile
GITHUB PR#7466
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
unameLinux ebebc47d8f28 5.15.0-130-generic#140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/bin/hadoop.sh
git revisiontrunk /c639f4f
Default JavaPrivate Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Test Resultshttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7466/1/testReport/
Max. process+thread count2824 (vs. ulimit of 5500)
modulesC: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
Console outputhttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7466/1/console
versionsgit=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.14.0https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

🎊+1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec20m 20sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any@author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+1 💚mvninstall40m 25strunk passed
+1 💚compile1m 14strunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚compile0m 41strunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚checkstyle0m 30strunk passed
+1 💚mvnsite0m 46strunk passed
+1 💚javadoc0m 43strunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javadoc0m 33strunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚spotbugs1m 30strunk passed
+1 💚shadedclient39m 14sbranch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚mvninstall0m 35sthe patch passed
+1 💚compile1m 3sthe patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javac1m 3sthe patch passed
+1 💚compile0m 33sthe patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚javac0m 33sthe patch passed
+1 💚blanks0m 1sThe patch has no blanks issues.
+1 💚checkstyle0m 20sthe patch passed
+1 💚mvnsite0m 37sthe patch passed
+1 💚javadoc0m 30sthe patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javadoc0m 25sthe patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚spotbugs1m 28sthe patch passed
+1 💚shadedclient39m 11spatch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚unit47m 50shadoop-hdfs-rbf in the patch passed.
+1 💚asflicense0m 36sThe patch does not generate ASF License warnings.
200m 47s
SubsystemReport/Notes
DockerClientAPI=1.48 ServerAPI=1.48 base:https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7466/3/artifact/out/Dockerfile
GITHUB PR#7466
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
unameLinux 4e6087e29435 5.15.0-130-generic#140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/bin/hadoop.sh
git revisiontrunk /43833f5
Default JavaPrivate Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Test Resultshttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7466/3/testReport/
Max. process+thread count2750 (vs. ulimit of 5500)
modulesC: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
Console outputhttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7466/3/console
versionsgit=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.14.0https://yetus.apache.org

This message was automatically generated.

@hfutatzhanghb
Copy link
ContributorAuthor

@Hexiaoqiao@KeeProMise Sir, PTAL at this pr when you have free time , thanks a lot.

@@ -355,7 +355,6 @@ public boolean mkdirs(String src, FsPermission masked, boolean createParent)
return rpcClient.invokeAll(locations, method);
}

asyncComplete(false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi,@hfutatzhanghb I just took a look at this method, and I think it should work fine without the modifications you suggested. First, set the completeFuture in the thread pool variable to false. Next, if locations.size() > 1, the completeFuture after execution will replace the thread variable. If locations.size() <= 1, then since the initial value of completeFuture is set to false, the subsequent asynchronous call code will be executed.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi,@KeeProMise , thanks for your reviewing. Have reverted mkdirs and other rpcs not affected by asyncComplete method to reduce code duplication. Thanks again.

@KeeProMise
Copy link
Member

Description of PR

May get wrong results due to the wrong usage of asyncComplete(null). Fix below RPCs : getMountPointStatus、getListing、getFileInfoAll、mkdirs

The root cause is as below:

asyncComplete(null);// Handler threadasyncApply(() -> {getFileInfo();// issue a rpc request.asyncApply();// AsyncRepsonder thread.});asyncApply(() -> {//do something.});// Handler thread, current thread's CompletableFuture object is in complete status.

How was this patch tested?

Add unit tests TestRouterAsyncMountTable.java.

How to reproduce?

Use original codes to run TestRouterAsyncMountTable.java Some of unit tests will not pass due to the inaccurate results.

asyncComplete(null);// Handler threadasyncApply(() -> {getFileInfo();// issue a rpc request.asyncApply();// AsyncRepsonder thread.});// The handler thread variable will be set to the CompletableFuture object after the execution of asyncApply.

look AsyncUtil#asyncApply(...)

publicstatic <T,R>voidasyncApply(ApplyFunction<T,R>function) {CompletableFuture<T>completableFuture =        (CompletableFuture<T>)CUR_COMPLETABLE_FUTURE.get();assertcompletableFuture !=null;CompletableFuture<R>result =function.apply(completableFuture);CUR_COMPLETABLE_FUTURE.set((CompletableFuture<Object>)result);// will reset CUR_COMPLETABLE_FUTURE use the CompletableFuture object after the execution  }

Comment on lines -502 to +516
returnnull;
returnfinalNamenodeListingExists;
});
} else {
asyncComplete(namenodeListingExists);
}
asyncComplete(namenodeListingExists);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this look good to me.

@hfutatzhanghbhfutatzhanghb changed the titleHDFS-17749. [ARR] Fix wrong results due to the wrong usage of asyncComplete(null).HDFS-17749. [ARR] Fix wrong results due to the wrong usage of asyncComplete in getListing.Mar 21, 2025
@hfutatzhanghbhfutatzhanghbforce-pushed theHDFS-17749 branch 3 times, most recently fromf2550b2 tof6dc774CompareMarch 21, 2025 06:00
@hadoop-yetus
Copy link

🎊+1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec20m 7sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 1scodespell was not available.
+0 🆗detsecrets0m 1sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any@author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+1 💚mvninstall40m 49strunk passed
+1 💚compile1m 12strunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚compile0m 41strunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚checkstyle0m 32strunk passed
+1 💚mvnsite0m 46strunk passed
+1 💚javadoc0m 42strunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javadoc0m 33strunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚spotbugs1m 32strunk passed
+1 💚shadedclient39m 31sbranch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚mvninstall0m 35sthe patch passed
+1 💚compile1m 5sthe patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javac1m 5sthe patch passed
+1 💚compile0m 33sthe patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚javac0m 33sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 21sthe patch passed
+1 💚mvnsite0m 37sthe patch passed
+1 💚javadoc0m 31sthe patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javadoc0m 24sthe patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚spotbugs1m 29sthe patch passed
+1 💚shadedclient38m 44spatch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚unit47m 47shadoop-hdfs-rbf in the patch passed.
+1 💚asflicense0m 37sThe patch does not generate ASF License warnings.
200m 49s
SubsystemReport/Notes
DockerClientAPI=1.48 ServerAPI=1.48 base:https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7466/4/artifact/out/Dockerfile
GITHUB PR#7466
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
unameLinux b0c09cddc1bb 5.15.0-130-generic#140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/bin/hadoop.sh
git revisiontrunk /a28d1c1
Default JavaPrivate Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Test Resultshttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7466/4/testReport/
Max. process+thread count2750 (vs. ulimit of 5500)
modulesC: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
Console outputhttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7466/4/console
versionsgit=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.14.0https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔-1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec9m 38sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any@author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+1 💚mvninstall24m 5strunk passed
+1 💚compile0m 34strunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚compile0m 23strunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚checkstyle0m 16strunk passed
+1 💚mvnsite0m 26strunk passed
+1 💚javadoc0m 24strunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javadoc0m 16strunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚spotbugs0m 57strunk passed
+1 💚shadedclient21m 46sbranch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚mvninstall0m 21sthe patch passed
+1 💚compile0m 31sthe patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javac0m 31sthe patch passed
+1 💚compile0m 20sthe patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚javac0m 20sthe patch passed
-1 ❌blanks0m 0s/blanks-eol.txtThe patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Referhttps://git-scm.com/docs/git-apply
-0⚠️checkstyle0m 10s/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txthadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 10 new + 2 unchanged - 0 fixed = 12 total (was 2)
+1 💚mvnsite0m 20sthe patch passed
+1 💚javadoc0m 17sthe patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javadoc0m 16sthe patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚spotbugs0m 58sthe patch passed
+1 💚shadedclient21m 22spatch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌unit50m 19s/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txthadoop-hdfs-rbf in the patch passed.
+1 💚asflicense0m 22sThe patch does not generate ASF License warnings.
134m 59s
ReasonTests
Failed junit testshadoop.hdfs.server.federation.router.TestRouterQuota
hadoop.hdfs.server.federation.router.TestRouterWithSecureStartup
SubsystemReport/Notes
DockerClientAPI=1.48 ServerAPI=1.48 base:https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7466/5/artifact/out/Dockerfile
GITHUB PR#7466
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
unameLinux 52ae32794cd7 5.15.0-130-generic#140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/bin/hadoop.sh
git revisiontrunk /f6dc774
Default JavaPrivate Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Test Resultshttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7466/5/testReport/
Max. process+thread count3190 (vs. ulimit of 5500)
modulesC: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
Console outputhttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7466/5/console
versionsgit=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.14.0https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔-1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec8m 49sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 1scodespell was not available.
+0 🆗detsecrets0m 1sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any@author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+1 💚mvninstall24m 1strunk passed
+1 💚compile0m 36strunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚compile0m 23strunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚checkstyle0m 17strunk passed
+1 💚mvnsite0m 26strunk passed
+1 💚javadoc0m 25strunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javadoc0m 17strunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚spotbugs0m 58strunk passed
+1 💚shadedclient21m 33sbranch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚mvninstall0m 19sthe patch passed
+1 💚compile0m 31sthe patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javac0m 31sthe patch passed
+1 💚compile0m 20sthe patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚javac0m 20sthe patch passed
-1 ❌blanks0m 0s/blanks-eol.txtThe patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Referhttps://git-scm.com/docs/git-apply
-0⚠️checkstyle0m 11s/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txthadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 10 new + 2 unchanged - 0 fixed = 12 total (was 2)
+1 💚mvnsite0m 20sthe patch passed
+1 💚javadoc0m 17sthe patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javadoc0m 14sthe patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚spotbugs0m 58sthe patch passed
+1 💚shadedclient21m 22spatch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌unit59m 18s/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txthadoop-hdfs-rbf in the patch passed.
+1 💚asflicense0m 23sThe patch does not generate ASF License warnings.
142m 50s
ReasonTests
Failed junit testshadoop.hdfs.server.federation.router.TestRouterQuota
hadoop.hdfs.server.federation.router.TestRouterWithSecureStartup
SubsystemReport/Notes
DockerClientAPI=1.48 ServerAPI=1.48 base:https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7466/6/artifact/out/Dockerfile
GITHUB PR#7466
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
unameLinux 38aec73d2000 5.15.0-130-generic#140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/bin/hadoop.sh
git revisiontrunk /f6dc774
Default JavaPrivate Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Test Resultshttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7466/6/testReport/
Max. process+thread count2471 (vs. ulimit of 5500)
modulesC: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
Console outputhttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7466/6/console
versionsgit=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.14.0https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔-1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec5m 24sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any@author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+1 💚mvninstall24m 17strunk passed
+1 💚compile0m 32strunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚compile0m 21strunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚checkstyle0m 16strunk passed
+1 💚mvnsite0m 25strunk passed
+1 💚javadoc0m 24strunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javadoc0m 17strunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚spotbugs0m 57strunk passed
+1 💚shadedclient21m 15sbranch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚mvninstall0m 20sthe patch passed
+1 💚compile0m 32sthe patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javac0m 32sthe patch passed
+1 💚compile0m 18sthe patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚javac0m 18sthe patch passed
-1 ❌blanks0m 0s/blanks-eol.txtThe patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Referhttps://git-scm.com/docs/git-apply
-0⚠️checkstyle0m 11s/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txthadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 10 new + 2 unchanged - 0 fixed = 12 total (was 2)
+1 💚mvnsite0m 20sthe patch passed
+1 💚javadoc0m 17sthe patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javadoc0m 14sthe patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚spotbugs0m 55sthe patch passed
+1 💚shadedclient21m 38spatch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌unit67m 6s/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txthadoop-hdfs-rbf in the patch passed.
+1 💚asflicense0m 25sThe patch does not generate ASF License warnings.
147m 27s
ReasonTests
Failed junit testshadoop.hdfs.server.federation.router.async.TestRouterAsyncRpcMultiDestination
hadoop.hdfs.server.federation.router.TestRouterQuota
hadoop.hdfs.server.federation.router.TestRouterWithSecureStartup
hadoop.hdfs.server.federation.router.TestRouterAllResolver
SubsystemReport/Notes
DockerClientAPI=1.48 ServerAPI=1.48 base:https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7466/7/artifact/out/Dockerfile
GITHUB PR#7466
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
unameLinux 035f9120898c 5.15.0-130-generic#140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/bin/hadoop.sh
git revisiontrunk /f6dc774
Default JavaPrivate Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Test Resultshttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7466/7/testReport/
Max. process+thread count2492 (vs. ulimit of 5500)
modulesC: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
Console outputhttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7466/7/console
versionsgit=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.14.0https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

🎊+1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 48sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 1scodespell was not available.
+0 🆗detsecrets0m 1sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any@author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+1 💚mvninstall41m 6strunk passed
+1 💚compile1m 40strunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚compile0m 47strunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚checkstyle0m 34strunk passed
+1 💚mvnsite0m 53strunk passed
+1 💚javadoc0m 51strunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javadoc0m 34strunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚spotbugs1m 46strunk passed
+1 💚shadedclient40m 57sbranch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚mvninstall0m 35sthe patch passed
+1 💚compile1m 4sthe patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javac1m 4sthe patch passed
+1 💚compile0m 33sthe patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚javac0m 33sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 20sthe patch passed
+1 💚mvnsite0m 36sthe patch passed
+1 💚javadoc0m 32sthe patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javadoc0m 25sthe patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚spotbugs1m 31sthe patch passed
+1 💚shadedclient39m 19spatch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚unit47m 59shadoop-hdfs-rbf in the patch passed.
+1 💚asflicense0m 38sThe patch does not generate ASF License warnings.
185m 6s
SubsystemReport/Notes
DockerClientAPI=1.48 ServerAPI=1.48 base:https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7466/8/artifact/out/Dockerfile
GITHUB PR#7466
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
unameLinux a59779799644 5.15.0-130-generic#140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/bin/hadoop.sh
git revisiontrunk /695c975
Default JavaPrivate Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Test Resultshttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7466/8/testReport/
Max. process+thread count2775 (vs. ulimit of 5500)
modulesC: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
Console outputhttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7466/8/console
versionsgit=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.14.0https://yetus.apache.org

This message was automatically generated.

Comment on lines +56 to +60
// Get the end points.
nnContext0 = cluster.getNamenode("ns0", null);
nnContext1 = cluster.getNamenode("ns1", null);
nnFs0 = nnContext0.getFileSystem();
nnFs1 = nnContext1.getFileSystem();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

hi@hfutatzhanghb Have these variables been used?

@hfutatzhanghb
Copy link
ContributorAuthor

hfutatzhanghb commentedMar 24, 2025 via email

yes, they were used in super class
---- Replied Message ----| From | ***@***.***> || Date | 03/24/2025 22:41 || To | ***@***.***> || Cc | ***@***.***>***@***.***> || Subject | Re: [apache/hadoop] HDFS-17749. [ARR] Fix wrong results due to the wrong usage of asyncComplete in getListing. (PR#7466) |@KeeProMise commented on this pull request.In hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/async/TestRouterAsyncMountTable.java:
+ // Get the end points.
+ nnContext0 = cluster.getNamenode("ns0", null);+ nnContext1 = cluster.getNamenode("ns1", null);+ nnFs0 = nnContext0.getFileSystem();+ nnFs1 = nnContext1.getFileSystem();hi@hfutatzhanghb Have these variables been used?—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

@hadoop-yetus
Copy link

🎊+1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 51sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any@author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+1 💚mvninstall41m 13strunk passed
+1 💚compile1m 15strunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚compile0m 41strunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚checkstyle0m 32strunk passed
+1 💚mvnsite0m 46strunk passed
+1 💚javadoc0m 43strunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javadoc0m 33strunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚spotbugs1m 33strunk passed
+1 💚shadedclient39m 12sbranch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚mvninstall0m 34sthe patch passed
+1 💚compile1m 4sthe patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javac1m 4sthe patch passed
+1 💚compile0m 33sthe patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚javac0m 33sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 21sthe patch passed
+1 💚mvnsite0m 37sthe patch passed
+1 💚javadoc0m 31sthe patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚javadoc0m 24sthe patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚spotbugs1m 30sthe patch passed
+1 💚shadedclient39m 42spatch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚unit48m 12shadoop-hdfs-rbf in the patch passed.
+1 💚asflicense0m 37sThe patch does not generate ASF License warnings.
183m 1s
SubsystemReport/Notes
DockerClientAPI=1.48 ServerAPI=1.48 base:https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7466/9/artifact/out/Dockerfile
GITHUB PR#7466
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
unameLinux 01f400d6e18a 5.15.0-130-generic#140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/bin/hadoop.sh
git revisiontrunk /e2581db
Default JavaPrivate Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Test Resultshttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7466/9/testReport/
Max. process+thread count2753 (vs. ulimit of 5500)
modulesC: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
Console outputhttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7466/9/console
versionsgit=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.14.0https://yetus.apache.org

This message was automatically generated.

Copy link
Member

@KeeProMiseKeeProMise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

@KeeProMiseKeeProMise merged commitfb30082 intoapache:trunkMar 25, 2025
4 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@KeeProMiseKeeProMiseKeeProMise approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@hfutatzhanghb@hadoop-yetus@KeeProMise
[8]ページ先頭
©2009-2025 Movatter.jp