- Notifications
You must be signed in to change notification settings - Fork691
Upgrade micrometer to version 1.14.0#7901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:develop
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@niallkp: As permailing list discussion, any chance you're able to review this? |
scmbuildguy commentedJun 24, 2025
@JinwooHwang-SAS Looks like there are build failures, do you think they are related to your changes? |
@scmbuildguy , I see -Werror in the build option which causes errors on warnings such as this deprecation message: import static io.micrometer.core.instrument.util.StringUtils.isNotBlank;
|
@niallkp and@scmbuildguy, I would appreciate it if you could kindly provide your response at your earliest convenience. Thank you. |
If you click the failing
|
Thank you for pointing that out and for sharing the detailed logs,@raboof. I really appreciate your guidance. I’ll review the develop / build failure carefully and see what steps we can take to address it. Your insights are very helpful in moving this forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
OK if CI agrees
Thank you@raboof |
raboof commentedAug 29, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The IntegrationTest failure seems (at least partly) related to this PR:
|
Thank you for bringing the IntegrationTest failure to my attention,@raboof. Let me investigate the issue in detail in order to determine the appropriate fix. I truly appreciate your careful review. |
Uh oh!
There was an error while loading.Please reload this page.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop
)?Is your initial contribution a single, squashed commit?
Does
gradlew build
run cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion underASF 2.0?