Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Upgrade micrometer to version 1.14.0#7901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
JinwooHwang wants to merge6 commits intoapache:develop
base:develop
Choose a base branch
Loading
fromJinwooHwang:micrometer

Conversation

JinwooHwang
Copy link
Contributor

@JinwooHwangJinwooHwang commentedJun 9, 2025
edited
Loading

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typicallydevelop)?

  • Is your initial contribution a single, squashed commit?

  • Doesgradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion underASF 2.0?

@semioticrobotic
Copy link
Contributor

@niallkp: As permailing list discussion, any chance you're able to review this?

@scmbuildguy
Copy link

@JinwooHwang-SAS Looks like there are build failures, do you think they are related to your changes?

@JinwooHwang
Copy link
ContributorAuthor

@scmbuildguy , I see -Werror in the build option which causes errors on warnings such as this deprecation message:
/home/runner/work/geode/geode/geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StopServerCommand.java:17: warning: [deprecation] StringUtils in io.micrometer.core.instrument.util has been deprecated

import static io.micrometer.core.instrument.util.StringUtils.isNotBlank;
^

Task :geode-gfsh:compileJava
error: warnings found and -Werror specified

@JinwooHwang
Copy link
ContributorAuthor

@niallkp and@scmbuildguy, I would appreciate it if you could kindly provide your response at your earliest convenience. Thank you.

@raboof
Copy link
Member

If you click the failingdevelop / build, you will see logs of the failure, including:

> Task :geode-gfsh:compileJava/home/runner/work/geode/geode/geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StopServerCommand.java:17: warning: [deprecation] StringUtils in io.micrometer.core.instrument.util has been deprecatedimport static io.micrometer.core.instrument.util.StringUtils.isNotBlank;                                                ^error: warnings found and -Werror specified1 error1 warning

@JinwooHwang
Copy link
ContributorAuthor

Thank you for pointing that out and for sharing the detailed logs,@raboof. I really appreciate your guidance. I’ll review the develop / build failure carefully and see what steps we can take to address it. Your insights are very helpful in moving this forward.

Copy link
Member

@raboofraboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

OK if CI agrees

@JinwooHwang
Copy link
ContributorAuthor

Thank you@raboof

@raboof
Copy link
Member

raboof commentedAug 29, 2025
edited
Loading

The IntegrationTest failure seems (at least partly) related to this PR:

    elements not found:      ["lib/HdrHistogram-2.1.12.jar", "lib/commons-io-2.11.0.jar"]    and elements not expected:      ["lib/HdrHistogram-2.2.2.jar",        "lib/commons-io-2.15.1.jar",        "lib/micrometer-commons-1.14.0.jar",        "lib/micrometer-observation-1.14.0.jar"]        at org.apache.geode.AssemblyContentsIntegrationTest.verifyAssemblyContents(AssemblyContentsIntegrationTest.java:67)

@JinwooHwang
Copy link
ContributorAuthor

Thank you for bringing the IntegrationTest failure to my attention,@raboof. Let me investigate the issue in detail in order to determine the appropriate fix. I truly appreciate your careful review.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@raboofraboofraboof approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JinwooHwang@semioticrobotic@scmbuildguy@raboof

[8]ページ先頭

©2009-2025 Movatter.jp