- Notifications
You must be signed in to change notification settings - Fork690
[DRAFT DO NOT REVIEW] WAN transactions extracted to module#7810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
albertogpz wants to merge1 commit intoapache:developChoose a base branch
base:develop
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
fca45a7 to422ba31Comparecommit4ce6664Author: Alberto Gomez <alberto.gomez@est.tech>Date: Tue Dec 14 19:30:37 2021 +0100 Fix testscommit77db403Author: Alberto Gomez <alberto.gomez@est.tech>Date: Tue Dec 14 18:43:41 2021 +0100 Added exceptions to public API changescommit8c2f77dAuthor: Alberto Gomez <alberto.gomez@est.tech>Date: Tue Dec 14 17:52:24 2021 +0100 Use --type=TxGroupingParallelGatewaySender... as suggested in jbarrett's reviewcommitcbe859dAuthor: Alberto Gomez <alberto.gomez@est.tech>Date: Mon Dec 13 12:36:50 2021 +0100 remove() refactored as suggested on jbarrett's reviewcommit43194d0Author: Alberto Gomez <alberto.gomez@est.tech>Date: Thu Dec 2 06:52:38 2021 +0100 Updated with Kirk's first review commentscommit0c3d814Author: Alberto Gomez <alberto.gomez@est.tech>Date: Fri Nov 5 08:16:10 2021 +0100 MODULE: Add gfsh create tx-grouping gw-sender cases.commita7416a3Author: Alberto Gomez <alberto.gomez@est.tech>Date: Fri Nov 5 08:15:46 2021 +0100 MODULE: Do not allow changing group-transaction-eventscommit74f9274Author: Alberto Gomez <alberto.gomez@est.tech>Date: Fri Nov 5 08:15:28 2021 +0100 MODULE: Fix some GatewaySenderFactoryImpl testscommit1959233Author: Alberto Gomez <alberto.gomez@est.tech>Date: Fri Nov 5 08:13:54 2021 +0100 MODULE: Move remaining tx-grouping functionality and DUnit testscommit5aa6bc7Author: Jacob Barrett <jbarrett@pivotal.io>Date: Wed Oct 13 19:50:56 2021 -0700 MODULE: Move testscommit07884e8Author: Jacob Barrett <jbarrett@pivotal.io>Date: Wed Oct 13 19:24:12 2021 -0700 MODULE: ServiceLoadercommit0be467bAuthor: Jacob Barrett <jbarrett@pivotal.io>Date: Wed Oct 13 16:31:02 2021 -0700 MODULE: Stupid simple module.commit477a823Author: Jacob Barrett <jbarrett@pivotal.io>Date: Wed Oct 13 16:08:08 2021 -0700 MODULE: Remove AbstractGatwaySender.mustGroupTransactionEvents()commitf7c0d21Author: Jacob Barrett <jbarrett@pivotal.io>Date: Wed Oct 13 14:14:38 2021 -0700 MODULE: Create TX grouping sender impls.commit35b072eAuthor: Jacob Barrett <jbarrett@pivotal.io>Date: Wed Oct 13 14:01:04 2021 -0700 MODULE: Extract out TX grouping factories.commit7a3d45cAuthor: Jacob Barrett <jbarrett@pivotal.io>Date: Wed Oct 13 13:19:15 2021 -0700 MODULE: Split out some factories.commitae74a42Author: Jacob Barrett <jbarrett@pivotal.io>Date: Thu Sep 30 15:24:56 2021 -0700 MODULE: Extract interface for GatewaySenderAttributes.commit8c2d23eAuthor: Jacob Barrett <jbarrett@pivotal.io>Date: Thu Sep 30 17:22:04 2021 -0700 GEODE-6588: Cleanup GatewaySenderFactoryImplcommit2457963Author: Jacob Barrett <jbarrett@pivotal.io>Date: Thu Sep 30 16:07:40 2021 -0700 GEODE-6588: Cleanup AbstractGatewaySendercommit042013dAuthor: Jacob Barrett <jbarrett@pivotal.io>Date: Thu Sep 30 14:54:03 2021 -0700 GEODE-6588: Cleanup GatewaySenderAttributes
422ba31 to22fad08CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit4ce6664
Author: Alberto Gomezalberto.gomez@est.tech
Date: Tue Dec 14 19:30:37 2021 +0100
commit77db403
Author: Alberto Gomezalberto.gomez@est.tech
Date: Tue Dec 14 18:43:41 2021 +0100
commit8c2f77d
Author: Alberto Gomezalberto.gomez@est.tech
Date: Tue Dec 14 17:52:24 2021 +0100
commitcbe859d
Author: Alberto Gomezalberto.gomez@est.tech
Date: Mon Dec 13 12:36:50 2021 +0100
commit43194d0
Author: Alberto Gomezalberto.gomez@est.tech
Date: Thu Dec 2 06:52:38 2021 +0100
commit0c3d814
Author: Alberto Gomezalberto.gomez@est.tech
Date: Fri Nov 5 08:16:10 2021 +0100
commita7416a3
Author: Alberto Gomezalberto.gomez@est.tech
Date: Fri Nov 5 08:15:46 2021 +0100
commit74f9274
Author: Alberto Gomezalberto.gomez@est.tech
Date: Fri Nov 5 08:15:28 2021 +0100
commit1959233
Author: Alberto Gomezalberto.gomez@est.tech
Date: Fri Nov 5 08:13:54 2021 +0100
commit5aa6bc7
Author: Jacob Barrettjbarrett@pivotal.io
Date: Wed Oct 13 19:50:56 2021 -0700
commit07884e8
Author: Jacob Barrettjbarrett@pivotal.io
Date: Wed Oct 13 19:24:12 2021 -0700
commit0be467b
Author: Jacob Barrettjbarrett@pivotal.io
Date: Wed Oct 13 16:31:02 2021 -0700
commit477a823
Author: Jacob Barrettjbarrett@pivotal.io
Date: Wed Oct 13 16:08:08 2021 -0700
commitf7c0d21
Author: Jacob Barrettjbarrett@pivotal.io
Date: Wed Oct 13 14:14:38 2021 -0700
commit35b072e
Author: Jacob Barrettjbarrett@pivotal.io
Date: Wed Oct 13 14:01:04 2021 -0700
commit7a3d45c
Author: Jacob Barrettjbarrett@pivotal.io
Date: Wed Oct 13 13:19:15 2021 -0700
commitae74a42
Author: Jacob Barrettjbarrett@pivotal.io
Date: Thu Sep 30 15:24:56 2021 -0700
commit8c2d23e
Author: Jacob Barrettjbarrett@pivotal.io
Date: Thu Sep 30 17:22:04 2021 -0700
commit2457963
Author: Jacob Barrettjbarrett@pivotal.io
Date: Thu Sep 30 16:07:40 2021 -0700
commit042013d
Author: Jacob Barrettjbarrett@pivotal.io
Date: Thu Sep 30 14:54:03 2021 -0700
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion underASF 2.0?