Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DRAFT DO NOT REVIEW] Make ObserverHolder thread safe by having a thread local observer member#6882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
albertogpz wants to merge7 commits intoapache:develop
base:develop
Choose a base branch
Loading
fromNordix:query_observer_holder_thread_local

Conversation

albertogpz
Copy link
Contributor

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typicallydevelop)?

  • Is your initial contribution a single, squashed commit?

  • Doesgradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion underASF 2.0?

@lgtm-com
Copy link

This pull requestintroduces 1 alert when merging64fe5c2 intoc68a770 -view on LGTM.com

new alerts:

  • 1 for Inconsistent synchronization of getter and setter

@albertogpzalbertogpzforce-pushed thequery_observer_holder_thread_local branch from64fe5c2 to2a98a10CompareSeptember 20, 2021 18:07
@albertogpzalbertogpzforce-pushed thequery_observer_holder_thread_local branch from2a98a10 to141e30fCompareSeptember 20, 2021 18:10
@onichols-pivotal
Copy link
Contributor

this PR appears to be abandoned, can it be closed?

Copy link
Contributor

@onichols-pivotalonichols-pivotal left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

comment deleted

@albertogpz
Copy link
ContributorAuthor

this PR appears to be abandoned, can it be closed?

I would prefer not to close it yet as it is an alternative approach to#6874 as it is mentioned in the comments.

onichols-pivotal reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@onichols-pivotalonichols-pivotalonichols-pivotal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@albertogpz@onichols-pivotal
[8]ページ先頭
©2009-2025 Movatter.jp