- Notifications
You must be signed in to change notification settings - Fork421
feat: support Java Platform Module System#618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR adds support for the Java Platform Module System (JPMS) to Apache Fesod, enabling the library to be used as a named module in Java 9+ environments while maintaining Java 8 compatibility.
- Adds JPMS module descriptor (
module-info.java
) with appropriate exports and dependencies - Implements comprehensive module tests to verify module functionality and consumer usage
- Updates build configuration to compile module descriptor only on JDK 9+
- Refactors test utilities to work properly in modular environments
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
fesod/src/main/java9/module-info.java | Defines the JPMS module with exports and dependencies |
fesod/pom.xml | Adds Java 9+ profile for module compilation and testing |
fesod/src/test/java9/org/apache/fesod/excel/module/*.java | Module-specific tests for verification |
fesod/src/test/java/org/apache/fesod/excel/util/TestFileUtil.java | Refactored for module path compatibility |
website/**.md | Documentation updates for module maintenance |
Tip: Customize your code reviews with copilot-instructions.md.Create the file orlearn how to get started.
fesod/src/test/java9/org/apache/fesod/excel/module/ConsumerModuleUsageTest.javaShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
fesod/src/test/java9/org/apache/fesod/excel/module/ConsumerModuleUsageTest.javaShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Purpose of the pull request
Related:#101#332
Still confuse on the verification
What's changed?
java9 folder for JDK 9+ compile
Checklist