Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: support Java Platform Module System#618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
alaahong wants to merge4 commits intoapache:main
base:main
Choose a base branch
Loading
fromalaahong:feature/java_module

Conversation

alaahong
Copy link
Member

Purpose of the pull request

Related:#101#332
Still confuse on the verification

What's changed?

java9 folder for JDK 9+ compile

Checklist

  • I have read theContributor Guide.
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

delei reacted with thumbs up emoji
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR adds support for the Java Platform Module System (JPMS) to Apache Fesod, enabling the library to be used as a named module in Java 9+ environments while maintaining Java 8 compatibility.

  • Adds JPMS module descriptor (module-info.java) with appropriate exports and dependencies
  • Implements comprehensive module tests to verify module functionality and consumer usage
  • Updates build configuration to compile module descriptor only on JDK 9+
  • Refactors test utilities to work properly in modular environments

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
FileDescription
fesod/src/main/java9/module-info.javaDefines the JPMS module with exports and dependencies
fesod/pom.xmlAdds Java 9+ profile for module compilation and testing
fesod/src/test/java9/org/apache/fesod/excel/module/*.javaModule-specific tests for verification
fesod/src/test/java/org/apache/fesod/excel/util/TestFileUtil.javaRefactored for module path compatibility
website/**.mdDocumentation updates for module maintenance

Tip: Customize your code reviews with copilot-instructions.md.Create the file orlearn how to get started.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@psxjoypsxjoyAwaiting requested review from psxjoy

@deleideleiAwaiting requested review from delei

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@alaahong

[8]ページ先頭

©2009-2025 Movatter.jp