- Notifications
You must be signed in to change notification settings - Fork5k
[Fix-17710][Master] Fix master task dispatch failure by filtering out null map keys.#17711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:dev
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| // of the process instance complement | ||
| ICommandParamcommandParam =JSONUtils.parseObject(workflowInstance.getCommandParam(),ICommandParam.class); | ||
| StringtimeZone =commandParam.getTimeZone(); | ||
| StringtimeZone =commandParam !=null ?commandParam.getTimeZone() :null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
commandParam shouldn't be null.
| // stream pass params | ||
| List<Property>varPools =parseVarPool(taskInstance); | ||
| Map<String,Property>prepareParamsMap =newHashMap<>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Revert the unrelated changes.
| // 7. Resolve placeholders (e.g., "${output_dir}") using the current parameter context | ||
| resolvePlaceholders(prepareParamsMap); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
preBuildBusinessParams should beforeresolvePlaceholders?
Purpose of the pull request
close#17710
Brief change log
add filter some null map keys and unit test
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as(please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md