- Notifications
You must be signed in to change notification settings - Fork4.8k
[Improvement-284][auth] Add generalized OIDC authentication with multi-provider support#17119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
+316 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…ovider configuration- Implemented pluggable OIDC support with Keycloak and Dex compatibility- Added GenericOidcAuthenticator and OidcService for dynamic OIDC login- Introduced config-driven provider support via �pplication.yaml- Extended LoginController to handle OIDC redirects and session creation- Enables scalable authentication using OIDC-compliant providers beyond CasdoorRelated to: GSOC-284
Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md) |
| @SneakyThrows | ||
| @Operation(summary = "redirectToOidc", description = "REDIRECT_TO_OIDC_LOGIN") | ||
| @GetMapping("redirect/login/oidc") | ||
| public void loginByOidc(@RequestParam String code, @RequestParam String provider, |
Check failure
Code scanning / CodeQL
HTTP request type unprotected from CSRF High
Potential CSRF vulnerability due to using an HTTP request type which is not default-protected from CSRF for an apparent
state-changing action
Error loading related location
Loading| @Operation(summary = "redirectToOidc", description = "REDIRECT_TO_OIDC_LOGIN") | ||
| @GetMapping("redirect/login/oidc") | ||
| public void loginByOidc(@RequestParam String code, @RequestParam String provider, | ||
| HttpServletRequest request, HttpServletResponse response) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
The parameter 'request' is never used.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GSoC 2025
OidcService: Handles token exchange and user session handling.
OidcUserInfo: Extracts user info from ID token.
OidcConfiguration
OidcAuthenticationConfig These allow dynamic provider setup via application.yaml.
Redirect to the appropriate OIDC provider based on request.
Handle callback, extract user info, create session, and redirect back with session ID.