NotificationsYou must be signed in to change notification settings
Fork2.4k
Star4.9k

[CALCITE-6912] Test showing a sample failure of Enumerable codes handling of byte[] columns#4263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

chrisdennis wants to merge1 commit intoapache:main

base:main

Choose a base branch

fromchrisdennis:calcite-6912

Draft

[CALCITE-6912] Test showing a sample failure of Enumerable codes handling of byte[] columns#4263

chrisdennis wants to merge1 commit intoapache:mainfromchrisdennis:calcite-6912

Conversation

Copy link

chrisdennis commentedMar 25, 2025

This test fails due to the impossible cast of byte[] to ByteString in the moveNext() method:

public org.apache.calcite.linq4j.Enumerable bind(final org.apache.calcite.DataContext root) {  final org.apache.calcite.linq4j.Enumerable _inputEnumerable = org.apache.calcite.linq4j.Linq4j.asEnumerable(((org.apache.calcite.test.schemata.catchall.CatchallSchema) ((org.apache.calcite.adapter.java.ReflectiveSchema) root.getRootSchema().getSubSchema("s").unwrap(org.apache.calcite.adapter.java.ReflectiveSchema.class)).getTarget()).everyTypes).select(new org.apache.calcite.linq4j.function.Function1() {    public org.apache.calcite.test.schemata.catchall.CatchallSchema.EveryType apply(org.apache.calcite.test.schemata.catchall.CatchallSchema.EveryType row) {      return new org.apache.calcite.test.schemata.catchall.CatchallSchema.EveryType(          row.primitiveBoolean,          row.primitiveByte,          row.primitiveChar,          row.primitiveShort,          row.primitiveInt,          row.primitiveLong,          row.primitiveFloat,          row.primitiveDouble,          row.wrapperBoolean,          row.wrapperByte,          row.wrapperCharacter,          row.wrapperShort,          row.wrapperInteger,          row.wrapperLong,          row.wrapperFloat,          row.wrapperDouble,          row.sqlDate,          row.sqlTime,          row.sqlTimestamp,          row.utilDate,          row.string,          row.bigDecimal,          row.list,          row.bytes);    }    public Object apply(Object row) {      return apply(        (org.apache.calcite.test.schemata.catchall.CatchallSchema.EveryType) row);    }  }  );  return new org.apache.calcite.linq4j.AbstractEnumerable(){      public org.apache.calcite.linq4j.Enumerator enumerator() {        return new org.apache.calcite.linq4j.Enumerator(){            public final org.apache.calcite.linq4j.Enumerator inputEnumerator = _inputEnumerable.enumerator();            public void reset() {              inputEnumerator.reset();            }            public boolean moveNext() {              while (inputEnumerator.moveNext()) {                final byte[] input_value = ((org.apache.calcite.test.schemata.catchall.CatchallSchema.EveryType) inputEnumerator.current()).bytes;                final org.apache.calcite.avatica.util.ByteString cast_value = input_value == null ? null : (org.apache.calcite.avatica.util.ByteString) input_value;                final byte[] value_dynamic_param = (byte[]) root.get("?0");                final org.apache.calcite.avatica.util.ByteString cast_value0 = value_dynamic_param == null ? null : (org.apache.calcite.avatica.util.ByteString) value_dynamic_param;                final Boolean binary_call_value = cast_value == null || cast_value0 == null ? null : Boolean.valueOf(org.apache.calcite.runtime.SqlFunctions.eq(cast_value, cast_value0));                if (binary_call_value != null && org.apache.calcite.runtime.SqlFunctions.toBoolean(binary_call_value)) {                  return true;                }              }              return false;            }            public void close() {              inputEnumerator.close();            }            public Object current() {              return ((org.apache.calcite.test.schemata.catchall.CatchallSchema.EveryType) inputEnumerator.current()).primitiveBoolean;            }          };      }    };}public Class getElementType() {  return boolean.class;}

[CALCITE-6912] Test showing a sample failure of Enumerable codes hand…

6a3c3a1

…ling of byte[] columns

Copy link

github-actionsbot commentedApr 25, 2025

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on thedev@calcite.apache.org list. Thank you for your contributions.