- Notifications
You must be signed in to change notification settings - Fork4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Handle missing tables more gracefully.#33610
base:master
Are you sure you want to change the base?
Conversation
_get_table_size can return None in some instances (such as bad credentials) which will cause an operator error. Let's handle that more gracefully.
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on thedev@beam.apache.org list. Thank you for your contributions. |
_get_table_size can return None in some instances (such as bad credentials) which will cause an operator error at runtime. Let's handle that more gracefully by interpreting None as 0.
NB This is a very minor change, so I'm skipping some hoops. Apologies if that's not appropriate.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See theContributor Guide for more tips onhow to make review process smoother.
To check the build health, please visithttps://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
SeeCI.md for more information about GitHub Actions CI or theworkflows README to see a list of phrases to trigger workflows.