- Notifications
You must be signed in to change notification settings - Fork433
Remove widgets by widget id within the definition object#330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
sparksterz wants to merge1 commit intoangular-dashboard-framework:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Remove widgets by widget id within the definition object#330
sparksterz wants to merge1 commit intoangular-dashboard-framework:masterfromsparksterz:duplicate-widget-patch
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This fixes an edge type use case where someone editing a dashboard adds multiple of the same widget within the same column. Once removed, it doesn't find an index in subsequent removals of the same widget type, but it does remove it from the dashboard. As a result, the visual state of the widgets in a column differs (visual state removes widgets) from the object (subsequent widgets of the same type stay in the column after the first removal), unless using the widget id to identify a unique entry.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an edge type use case where someone editing a dashboard adds multiple of the same widget within the same column. Once removed, it doesn't find an index in subsequent removals of the same widget type, but it does remove it from the dashboard. As a result, the visual state of the widgets in a column differs (visual state removes widgets) from the object (subsequent widgets of the same type stay in the column after the first removal), unless using the widget id to identify a unique entry.