Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Replaced Sortable with ng-sortable#166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
bojanbass wants to merge3 commits intoangular-dashboard-framework:master
base:master
Choose a base branch
Loading
frombojanbass:master

Conversation

@bojanbass
Copy link

Hi,

I made a replacement inside column directive to use ng-sortable angular wrapper for Sortable library. I removed a lot of unused code from column directive this way. Please check, if it makes sense to use this one in your framework. A downside is that we have to include a new js library ng-sortable.js and inject it as angular dependency at startup. I also fixed the sample code to work with these changes.

Regards.

replaced Sortable with ng-sortable wrapperchanged sample to use ng-sortable
@sdorrasdorra added this to thenext milestoneOct 18, 2015
@sdorrasdorra self-assigned thisOct 18, 2015
@sdorra
Copy link
Member

We had some problems with ng-sortable, during the drag and drop implementation with sortable (in particular with deactivated debug mode). It looks that the debug mode problem is fixed (#255). We have todo some tests and we have to fix the unit tests, but i think it is a great idea to replace the drag and drop code with the ng-sortable directive.

@sdorra
Copy link
Member

I've done some tests with the samples and i got a lot of issues:

Uncaught TypeError: Cannot read property 'splice' of undefinedUncaught TypeError: Cannot read property 'options' of null

@bojanbass
Copy link
Author

Could you tell me which actions caused these errors? Also I forgot to fix unit tests.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

@sdorrasdorra

Projects

None yet

Milestone

next

Development

Successfully merging this pull request may close these issues.

3 participants

@bojanbass@sdorra@dependencies-bot

[8]ページ先頭

©2009-2025 Movatter.jp