NotificationsYou must be signed in to change notification settings
Fork2.2k
Star7.8k

fix: Avoid handling promise rejections twice in stability helper#3657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

jamesdaniels merged 1 commit intoangular:mainfromatscott:pendingtasksadd

Jun 12, 2025

Merged

fix: Avoid handling promise rejections twice in stability helper#3657

jamesdaniels merged 1 commit intoangular:mainfromatscott:pendingtasksadd

Jun 12, 2025

Conversation

Copy link

Contributor

atscott commentedJun 6, 2025

PendingTasks.run reports rejections of the promise to theErrorHandler. This function already returns a promise that is meant to be handled in the developer's application. If thereis handling there, the rejection is handled both in thePendingTasks.run and in the developer callsite.

This change updates the code to usePendingTasks.add instead, which has no built in error handling mechanisms.

fixesangular/angular#61932

fix: Avoid handling promise rejections twice in stability helper

695d4c5

`PendingTasks.run` reports rejections of the promise to the`ErrorHandler`. This function already returns a promise that is meant tobe handled in the developer's application. If there _is_ handling there,the rejection is handled both in the `PendingTasks.run` and in thedeveloper callsite.This change updates the code to use `PendingTasks.add` instead, whichhas no built in error handling mechanisms.fixesangular/angular#61932