feat($route): regexp support for $route params#972

Closed

petrovalex wants to merge1 commit intoangular:masterfrompetrovalex:route-regex

Closed

feat($route): regexp support for $route params#972

petrovalex wants to merge1 commit intoangular:masterfrompetrovalex:route-regex

Conversation

Copy link

Contributor

petrovalex commentedMay 20, 2012

Commit related to the issue#918

regex for the route is constructed once and then reused
allows provide regex expressions for params in the constraints object:
$routeProvider.when('/user/:id/:age', {template:'user.html'}, {id:"[0-9]", age:"[0-9]"})
list of values is supported using regular expression:
$routeProvider.when('/some/:param', {template:'foo.html'}, {param:"one|two|tree"});
supports predefined types for paramsters (int, float, bool, string):
$routeProvider.when('/some/:param', {template:'foo.html'}, {param:"float"});
$routeParams.param will be typeof number
predefined types can be extended, bu extending $routeProvider.shortcut object

Thanks for your contribution! In order for us to be able to accept it, we ask you to sign our CLA (contributor's license agreement).

CLA is important for us to be able to avoid legal troubles down the road.

For individuals (a simple click-through form):
http://code.google.com/legal/individual-cla-v1.0.html

For corporations (print, sign and scan+email, fax or mail):
http://code.google.com/legal/corporate-cla-v1.0.html

- regexp support for $route params

4521530

Copy link

freewind commentedJul 6, 2012

Hope angularjs team can review/merge this pull request, I need this feature very much

Copy link

Contributor

mhevery commentedAug 31, 2012

Copy & Paste this into PRs: "Thanks for your contribution! In order for us to be able to accept it, we ask you to sign our CLA (contributor's license agreement).

CLA is important for us to be able to avoid legal troubles down the road.

For individuals (a simple click-through form):
http://code.google.com/legal/individual-cla-v1.0.html

For corporations (print, sign and scan+email, fax or mail):
http://code.google.com/legal/corporate-cla-v1.0.html"

ghost assignedmhevery

Sep 4, 2012

Copy link

Contributor

Thanks for the PR, and very sorry about the delay in getting to it. Unfortunately this feature is not yet done. There are few use cases outlined in comments which do not work, and the PR is missing documentation. Could you update it and rebase to master and we will have another look. We promise not to take 3 months again. Again sorry about the delay.

I understand this may not be a priority for you, so I am going to close this request so that it does not show up in our list. Once you update the changes requested please reopen the request.