This repository was archived by the owner on Apr 12, 2024. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork27.4k
Escaped "short" word and added ability to stop updatingRoute in beforeUpdateRoute#577
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Closing this PR. We are that we want api for canceling the route change, but it's not that simple (we need to revert the $location), so here is an issue for that:#592 |
Currently in our project we are reverting location url in more less this way this.$on("$beforeRouteChange", function(scope, next, current, stopCallback) {
}); It could be integrated inside $route service. |
yep, the problem is, when route change is induced by outside change (browser's url change) - e.g. user has typed into address bar or clicked on link (in hashbang $location mode)... We have to consider these cases as well... |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.