Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
/angular.jsPublic archive

chore(build): support NodeJS LTS v14. fix audit issues#17139

Closed

Conversation

Splaktar
Copy link
Contributor

@SplaktarSplaktar commentedJun 5, 2021
edited
Loading

AngularJS is in LTS mode

We are no longer accepting changes that are not critical bug fixes into this project.
Seehttps://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c for more detail.

Does this PR fix a regression since 1.7.0, a security flaw, or a problem caused by a new browser version?
Yes

What is the current behavior? (You can also link to an open issue here)

  • from:483 vulnerabilities found - 273 Low | 38 Moderate | 168 High | 4 Critical
  • NodeJS v12 is used

What is the new behavior (if this is a feature change)?

  • to: 389 vulnerabilities found - 259 Low | 28 Moderate | 98 High | 4 Critical
  • NodeJS LTS v14 is used, the same version as the other Angular repos.

Does this PR introduce a breaking change?
No

Please check if the PR fulfills these requirements

  • The commit message follows ourguidelines
  • Fix/Feature:Docs have been added/updated
  • Fix/Feature: Tests have been added; existing tests pass

Other information:

  • This doesn't fix audit issues with the Firebase functions. I plan to do that in a separate PR.
  • This doesn't fix all audit issues as I wanted to keep this to a smaller batch as I anticipate future fixes to have more widely breaking changes. This batch is lower risk.
  • I tested doc gen and rendering, commit log generation, and building manually in addition to the CI tests.

- from:483 vulnerabilities found - 273 Low | 38 Moderate | 168 High | 4 Critical- to: 389 vulnerabilities found - 259 Low | 28 Moderate | 98 High | 4 Critical
gkalpak pushed a commit that referenced this pull requestJun 5, 2021
- from:483 vulnerabilities found - 273 Low | 38 Moderate | 168 High | 4 Critical- to: 389 vulnerabilities found - 259 Low | 28 Moderate | 98 High | 4 CriticalCloses#17139
@SplaktarSplaktar deleted the fix-audit-warnings branchJune 5, 2021 19:14
AnkushLambdatest pushed a commit to AnkushLambdatest/angular.js that referenced this pull requestJun 29, 2022
- from:483 vulnerabilities found - 273 Low | 38 Moderate | 168 High | 4 Critical- to: 389 vulnerabilities found - 259 Low | 28 Moderate | 98 High | 4 CriticalClosesangular#17139
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@gkalpakgkalpakgkalpak approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Splaktar@gkalpak

[8]ページ先頭

©2009-2025 Movatter.jp