This repository was archived by the owner on Apr 12, 2024. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork27.4k
Added disclaimer about the level of experience required in the first paragraph to beginning users.#17068
Open
stevenrugg wants to merge1 commit intoangular:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
added disclaimer for beginning users
googlebot commentedAug 28, 2020
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝Please visithttps://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️Googlers:Go here for more info. |
I signed it …________________________________From: googlebot <notifications@github.com>Sent: Friday, August 28, 2020 5:03 AMTo: angular/angular.js <angular.js@noreply.github.com>Cc: Steven Rugg <Steven.rugg@outlook.com>; Author <author@noreply.github.com>Subject: Re: [angular/angular.js] Added disclaimer in the first paragraph to beginning users. (#17068)Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).📝 Please visithttps://cla.developers.google.com/ to sign.Once you've signed (or fixed any issues), please reply here with@googlebot I signed it! and we'll verify it. ________________________________What to do if you already signed the CLAIndividual signers * It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data<https://cla.developers.google.com/clas> and verify that your email is set on your git commits<https://help.github.com/articles/setting-your-email-in-git/>.Corporate signers * Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot<http://go/cla#troubleshoot> (Public version<https://opensource.google/docs/cla/#troubleshoot>). * The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data<https://cla.developers.google.com/clas> and verify that your email is set on your git commits<https://help.github.com/articles/setting-your-email-in-git/>. * The email used to register you as an authorized contributor must also be attached to your GitHub account<https://github.com/settings/emails>.ℹ️ Googlers: Go here<https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fangular%2Fangular.js%2Fpull%2F17068> for more info.—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub<#17068 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKPPUDAQSI2EYZSDHMT5GJDSC6MI7ANCNFSM4QOBXWZA>. |
googlebot commentedAug 30, 2020
CLAs look good, thanks! ℹ️Googlers:Go here for more info. |
@googlebot I signed it …________________________________From: googlebot <notifications@github.com>Sent: Friday, August 28, 2020 5:03 AMTo: angular/angular.js <angular.js@noreply.github.com>Cc: Steven Rugg <Steven.rugg@outlook.com>; Author <author@noreply.github.com>Subject: Re: [angular/angular.js] Added disclaimer in the first paragraph to beginning users. (#17068)Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).📝 Please visithttps://cla.developers.google.com/ to sign.Once you've signed (or fixed any issues), please reply here with@googlebot I signed it! and we'll verify it. ________________________________What to do if you already signed the CLAIndividual signers * It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data<https://cla.developers.google.com/clas> and verify that your email is set on your git commits<https://help.github.com/articles/setting-your-email-in-git/>.Corporate signers * Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot<http://go/cla#troubleshoot> (Public version<https://opensource.google/docs/cla/#troubleshoot>). * The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data<https://cla.developers.google.com/clas> and verify that your email is set on your git commits<https://help.github.com/articles/setting-your-email-in-git/>. * The email used to register you as an authorized contributor must also be attached to your GitHub account<https://github.com/settings/emails>.ℹ️ Googlers: Go here<https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fangular%2Fangular.js%2Fpull%2F17068> for more info.—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub<#17068 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKPPUDAQSI2EYZSDHMT5GJDSC6MI7ANCNFSM4QOBXWZA>. |
Splaktar suggested changesSep 30, 2020
| @@ -5,6 +5,11 @@ | |||
| # PhoneCat Tutorial App | |||
| *** This tutorial assumes that the reader has a basic knowledge of HTML, CSS and Javascript. If you have no | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Suggested change
| *** This tutorial assumes that the reader has abasic knowledge of HTML, CSS andJavascript. If you have no | |
| *** This tutorial assumes that the reader has afundamental knowledge of HTML, CSS, andJavaScript. If you have no |
| @@ -5,6 +5,11 @@ | |||
| # PhoneCat Tutorial App | |||
| *** This tutorial assumes that the reader has a basic knowledge of HTML, CSS and Javascript. If you have no | |||
| experience coding or have not been introduced to Javascript, we highly suggest that you take some time | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Suggested change
| experience coding or have not been introduced toJavascript, we highly suggest that you take some time | |
| experience coding or have not been introduced toJavaScript, we highly suggest that you take some time |
| @@ -5,6 +5,11 @@ | |||
| # PhoneCat Tutorial App | |||
| *** This tutorial assumes that the reader has a basic knowledge of HTML, CSS and Javascript. If you have no | |||
| experience coding or have not been introduced to Javascript, we highly suggest that you take some time | |||
| to learn the basics of Javascript by going to https://www.javascript.com/learn/strings or | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Suggested change
| to learn the basics ofJavascript by going to https://www.javascript.com/learn/strings or | |
| to learn the basics ofJavaScript by going to[MDN's JavaScript guide](https://developer.mozilla.org/en-US/docs/Web/JavaScript). |
| *** This tutorial assumes that the reader has a basic knowledge of HTML, CSS and Javascript. If you have no | ||
| experience coding or have not been introduced to Javascript, we highly suggest that you take some time | ||
| to learn the basics of Javascript by going to https://www.javascript.com/learn/strings or | ||
| https://www.w3schools.com/js/. *** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Suggested change
| https://www.w3schools.com/js/. *** |
Also from CI: You can find more athttps://github.com/angular/angular.js/blob/master/DEVELOPERS.md#commits |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
added disclaimer for beginning users
AngularJS is in LTS mode
We are no longer accepting changes that are not critical bug fixes into this project.
Seehttps://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c for more detail.
Does this PR fix a regression since 1.7.0, a security flaw, or a problem caused by a new browser version?
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information: