This repository was archived by the owner on Apr 12, 2024. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork27.4k
log usable error on unhandled non error rejections Fixes #15816#15818
Open
graingert wants to merge1 commit intoangular:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
log usable error on unhandled non error rejections Fixes #15816#15818
graingert wants to merge1 commit intoangular:masterfromgraingert:log-usable-error-on-unhandled-non-error-rejections
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Follow up to#15527 |
dca6b76 toc98fee1CompareWe need tests. |
Is this a feature you want? Do you like the implementation? …On 21 Mar 2017 2:24 pm, "George Kalpakas" ***@***.***> wrote: We need tests. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#15818 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAZQTP1v2Jtito9NC42ZXpIuaV2Nj1H3ks5rn8-CgaJpZM4MeBdk> . |
I never look at the implementation if there are no tests 😛 |
All the extra state should be totally hidden until it hits the unhandledrejection code …On 21 Mar 2017 15:31, "George Kalpakas" ***@***.***> wrote: I never look at the implementation if there are no tests 😛 If we can have the feature in a consistent way and without hurting working usecases, it is fine (but I am not sure it is possible). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#15818 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAZQTHL4OVim7SRXO4wvXxz7jzCXL4mNks5rn99EgaJpZM4MeBdk> . |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
#15816
What is the new behavior (if this is a feature change)?
#15816
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information: