feat(ngHref): bind href attribute to ng-href attribute in case SVG el…#15694

Open

m-amr wants to merge1 commit intoangular:master

base:master

Choose a base branch

fromm-amr:bind_href_in_svg

Open

feat(ngHref): bind href attribute to ng-href attribute in case SVG el…#15694

m-amr wants to merge1 commit intoangular:masterfromm-amr:bind_href_in_svg

Conversation

Copy link

Contributor

m-amr commentedFeb 9, 2017•
edited
Loading

…ement

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature that solve#15618

What is the current behavior? (You can also link to an open issue here)
href attribute doesn't bind to ng-href in case of SVG element

What is the new behavior (if this is a feature change)?
href attribute binds to ng-href in case of SVG element

Does this PR introduce a breaking change?
No

Please check if the PR fulfills these requirements

The commit message follows our guidelines:https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Other information:

googlebot added the cla: yes label

Feb 9, 2017

m-amr force-pushed thebind_href_in_svg branch 2 times, most recently from43ebe65 toc400a29Compare

February 9, 2017 04:47

Copy link

Member

gkalpak commentedFeb 9, 2017

I think we will need a lot more changes (e.g.here,here,here and probably elsewhere) and more tests and security reviews. TBH, I am not sure it is worth it at this point (until the spec is finallized and implemented by browsers).