- Notifications
You must be signed in to change notification settings - Fork27.4k
Add traceback to unhandled promise rejections#15522
Uh oh!
There was an error while loading.Please reload this page.
Conversation
graingert commentedDec 19, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This could break people relying on unhandled rejections never being real exceptions. To be non-breaking we could add a |
Actually, the "juicy info" does already exist. It is just stringified into a less juicy |
@gkalpak stringifying the exception breaks trace-back info because angular doesn't stringify errors properly. Angular calls Errors 'exceptions' and brutally stringifies them before they can be safely carried to the gentle, sweet, embrace of window.onerror. |
graingert commentedDec 19, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
gkalpak commentedDec 19, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
That's what I meant by "we need to fix it". Embarrassing as it may be, I have to admit I did not realize this was a PR, until now. I thought it was an issue 😳 Sorry, for not paying attention and thx for your perseverance. I promise I'll treat#15527 rightly 😛 |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
Console is filled with meaningless:
Possibly unhandled rejection: {}
errorsWhat is the new behavior (if this is a feature change)?
Console is filled with juicy traceback info.
Does this PR introduce a breaking change?
I don't think so
Please check if the PR fulfills these requirements
Other information: