This repository was archived by the owner on Apr 12, 2024. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork27.4k
fix($resource) Route constructor, updated RegExp#1402
Closed
fredrikbonander wants to merge3 commits intoangular:masterfromfredrikbonander:resource-relative-path
Closed
fix($resource) Route constructor, updated RegExp#1402
fredrikbonander wants to merge3 commits intoangular:masterfromfredrikbonander:resource-relative-path
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Update RegExp to allow urlParams with out leading slash (/).- Will allow reoucese to be loaded from a relative pathExample:var R = $resource(':path');R.get({ path : 'data.json' });Example usage:Load resources in applications not using webserver, ie local webapp in on a tablet.Thanks for your contribution! In order for us to be able to accept it, we ask you to sign our CLA (contributor's license agreement). CLA is important for us to be able to avoid legal troubles down the road. For individuals (a simple click-through form): For corporations (print, sign and scan+email, fax or mail): |
@mhevery Don't know how you get the registration, but it's filled out and posted. The individual one. |
this changed caused regressions. Resources with template: generate urls: should be: |
Updated the regexp (simplified it) and added test for your example. |
4 tasks
MERGED, thanks |
groner pushed a commit to groner/angular.js that referenced this pull requestNov 12, 2013
This reverts commit06ed8ef.The reverted commit causes regressions. See comments in the PR:angular#1402 (comment)
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update RegExp to allow urlParams with out leading slash (/).
Example:
var R = $resource(':path');
R.get({ path : 'data.json' });
Example usage:
Load resources in applications not using webserver, ie local webapp in on a tablet.